Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script that checks that all test oracles are compilable #51

Merged
merged 14 commits into from
Nov 27, 2023

Conversation

kelloggm
Copy link
Collaborator

I expect CI to fail. @LoiNguyenCS you should check the failures here and then make PRs that correct the bugs that it exposes. Once CI on this PR is green, we can merge it and then enforce this requirement for tests going forward.

@LoiNguyenCS
Copy link
Collaborator

I've figured out the problems. It was due to how Specimin handles import statements. If a class is deleted because it is not used by the target methods, Specimin should delete the import statements for that class in the final output too. Otherwise we've got an "unfound" error.

@LoiNguyenCS
Copy link
Collaborator

Professor,

I've made two changes on this branch. Specimin will now:

  1. Remove import statements that import unused classes.
  2. Try to use fully-qualified names to correct types, instead of simple names.

I am not sure why the CI is failing. Please take a look. Thank you.

@LoiNguyenCS
Copy link
Collaborator

When I tried running "typecheck_test_outputs.sh" in my local machine, I also got an error message without any further explanation.

@LoiNguyenCS
Copy link
Collaborator

Professor @kelloggm,

I have fixed the failure of CI.

Please take a look. Thank you.

Copy link
Collaborator

@LoiNguyenCS LoiNguyenCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (since I wrote the codes for these latest commits)

Copy link
Collaborator Author

@kelloggm kelloggm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned that your changes remove signature checker annotations. Given the timeline we're on, I'm okay with doing that for now. However, please open an issue indicating that there is a need to add more signature checker annotations on these classes, which we can return to after the ISSTA deadline.

Once you've done that and made the one other change I requested, this is ready to merge without another review.

@LoiNguyenCS LoiNguyenCS merged commit 72d9f6c into main Nov 27, 2023
1 check passed
@LoiNguyenCS LoiNguyenCS deleted the test-check-compilation branch November 27, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants