Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More highlighter-related test fixes #2

Merged
merged 1 commit into from
Feb 22, 2022
+1 −4
Merged

More highlighter-related test fixes #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...is-common/src/test/java/org/opensearch/analysis/common/HighlighterWithAnalyzersTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,6 @@ public void testSynonyms() throws IOException {
}
}

@AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/2063")
public void testPhrasePrefix() throws IOException {
Settings.Builder builder = Settings.builder()
.put(indexSettings())
Expand Down
1 change: 0 additions & 1 deletion ...arent-join/src/internalClusterTest/java/org/opensearch/join/query/ChildQuerySearchIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1832,7 +1832,6 @@ public void testHasParentInnerQueryType() {
assertSearchHits(searchResponse, "child-id");
}

@AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/2063")
public void testHighlightersIgnoreParentChild() throws IOException {
assertAcked(
prepareCreate("test").addMapping(
Expand Down
1 change: 0 additions & 1 deletion ...st/java/org/opensearch/search/fetch/subphase/highlight/AnnotatedTextHighlighterTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ public void testAnnotatedTextSingleFieldWithBreakIterator() throws Exception {
assertHighlightOneDoc("text", markedUpInputs, query, Locale.ROOT, breakIterator, 0, expectedPassages);
}

@AwaitsFix(bugUrl = "https://fixbugForLUCENE9")
public void testAnnotatedTextSingleFieldWithPhraseQuery() throws Exception {
final String[] markedUpInputs = { "[Donald Trump](Donald+Trump) visited Singapore", "Donald Jr was with Melania Trump" };
String[] expectedPassages = { "[Donald](_hit_term=donald) [Trump](_hit_term=trump) visited Singapore" };
Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/org/apache/lucene/util/packed/XPackedInts.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
/**
* Forked from Lucene 8.x; removed in Lucene 8.9
*
* @todo further investigate a better alternative
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javadoc check complains:

> Task :server:javadoc server/src/main/java/org/apache/lucene/util/packed/XPackedInts.java:38: error: unknown tag: todo
 * @todo further investigate a better alternative
   ^
1 error

* Todo: further investigate a better alternative
*
* Simplistic compression for array of unsigned long values. Each value is {@code >= 0} and {@code
* <=} a specified maximum value. The values are stored as packed ints, with each value consuming a
Expand Down