HTTP requests made via Stripe SDK hang

[kanadgupta]

Please avoid duplicates

• I checked all open bugs and none of them matched my problem.

Reproducible test case

https://github.com/kanadgupta/nock-beta-stripe-sdk

Nock Version

nock@14.0.0-beta.14

Node Version

v20.16.0

TypeScript Version

No response

What happened?

HTTP requests using Stripe's Node.js SDK will hang indefinitely if nock is loaded at all (whether or not there is an interceptor defined for the Stripe request).

I am not well-versed in nock nor in the Stripe SDK but I can confirm that this issue was not present in nock@14.0.0-beta.7 nor in nock@latest (e.g., before mswjs/interceptors was introduced).

Would you be interested in contributing a fix?

• yes

[mikicho]

Can you please remove the stripe dependency from your example?

[kanadgupta]

@mikicho the stripe dependency is a critical part of the issue so I'm not sure what removing it would accomplish. To clarify, the issue is with how nock is hanging on HTTP requests that are made by the stripe library.

I did a little bit of digging and I found this PR that might be related: stripe/stripe-node#1854 (which, funnily enough, is an effort to get the stripe library to play nicely with MSW 😅)

[mikicho]

Oh.. this is probably the problem. When you import http This way, we can't patch the http module. please change it in stripe module:
More info/Similar question: #2778

[kanadgupta]

@mikicho I considered opening up an issue the stripe repo, but I ended up flagging it here because the stripe library was working as expected in nock@14.0.0-beta.7 and in nock@latest. The issue started cropping up in nock@14.0.0-beta.8.

Plus it appears that the Stripe team has done some work on this front:
stripe/stripe-node#1844
stripe/stripe-node#1854
stripe/stripe-node#1866

Happy to raise an issue there if you are sure it's an issue with the Stripe SDK. Thanks for all your work on this, excited for a proper v14 release!

[mikicho]

Thanks! Can you please provide a more straightforward example without stripe? I don't want to debug the stripe package.

[sonntag-philipp]

This should be the exact location where the issue happens: https://github.com/stripe/stripe-node/blob/768206df1b9d025853d5e34e6046beb502effdd9/src/net/NodeHttpClient.ts#L83

Maybe this helps already.

[mikicho]

@sonntag-philipp Yes.. this is a limitation of our current interception implementation. We can't req.end inside the connect event.
As a workaround, you can explicitly call req.flushHeaders to make sure nock gets the request.

mswjs/interceptors#646

[kanadgupta]

I found that the workaround mentioned in this comment (thanks @jeyj0!) solves my problem. I've filed a bug report in the stripe-node repo: stripe/stripe-node#2211

@mikicho I'll keep this open and let you decide how to triage this.

[mikicho]

🎉

I'll close this one; we track this issue on the msw/interceptors repo.