fix: Solve the mismatch validator bug with final solution #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calmbeing
changed the title
brilliant-lx
approved these changes
Jun 20, 2023
setunapo
approved these changes
Jun 20, 2023
calmbeing
added a commit
to calmbeing/bsc-erigon
that referenced
this pull request
Jun 20, 2023
avatarH
added a commit
to node-real/bsc-erigon-avatar
that referenced
this pull request
Jul 3, 2023
add log add log fix bug? fix bug? update fix bug? fix bug? fix bug? add log add log add log add log add log add log fix fix add log add log fix bug remove log fix bug? add log fix bug fix bug add trace block diff by number rlp encode to json marshal update update storage key change to hex to test revert update feature: Step by step sync (node-real#116) Missed RPC calls implemented in BSC geth (node-real#83) * Add rpc calls that implemented in BSC geth but not in erigon * Register 'bsc' API module under 'eth' API namespace * Several missed calls implementation Fix bugs in trie hash computation solve the mismatch validator bug with final solution (node-real#135) update the version for bsc-erigon (node-real#136) Port Herzt upgrade: London & Berlin (node-real#138) optimization (node-real#131) release: prepare for release v1.1.2 (node-real#142) fix: log info System contract upgrade fix and RPC refine (node-real#146) * e2: avoid do RestoreCodeHash twice (erigontech#7706) - do it only once in HistoryStateReader * fix system contract upgrade * update --------- Co-authored-by: Alex Sharov <AskAlexSharov@gmail.com> update the config update the version remove log remove log remove log update diff layer return update update update update new try new try update update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve the mismatch validator bug with final solution:
Previously, sometimes "mismatching validator" error occur, after dive into more into the code, the root reason is that ibs(IntraBlockState) is not thread-safe, in evm system contract call, it'll read messy cache data.
With this commit, will create a new state for read validatorList to avoid messy cache data and thread-safe problem