Add/schedule #139
Add/schedule #139
Conversation
|
huuuuuuuuge |
anyway, please separate timetable PR and speaker page PR. |
|
Thank you @martinheidegger , @leader22 . I keep this PR open to review well. @leader22 please update website and attach timetable spreadsheet link if you have time. |
I think the speaker page is already published?! This just modifies the speakers page to use the same module. |
2018/src/confcal/interactive.confcal
Outdated
| 17:00-18:00 Lightning Talks | ||
| - Serverless in Scala on Node.js: Get Fast and Productive by Tatsuno Yasuhiro | ||
| - 私の生活を変えたHeadless Chrome by 大島 光貴 | ||
| - Deploy TypeScript with CodePipeline in Lambda by 石川 将吾 |
There was a problem hiding this comment.
The Speaker wants to change the title as below.
Would you be able to change it?
before: Deploy TypeScript with CodePipeline in Lambda
after: Deploy TypeScript with CodePipeline in Fargate
There was a problem hiding this comment.
Done in #139 (review)
|
I checked it on my Android 8 device and iPhone 5 - and it with the latest fixes it looks good. |
|
Thank you Very much. it is very helpful, But this pr is so huge, i don't have time to judge this PR is maintainable. |
|
I can make some effort and break it into a fewer parts. |
|
Internet Explorer does not react like in chrome the featured speaker is a little bit weird |
|
@Farid212 Thank you for testing. Indeed: IE doesn't support coloring. This can be fixed using pre-processing of the images. This is not related to this PR. |
| @@ -1,5 +1,5 @@ | |||
| 'use strict'; | |||
| const fs = require('fs'); | |||
| const fse = require('fse'); | |||
There was a problem hiding this comment.
what is fse ? I would like to be simple, fs is better, if you need promise, use fs.promises or bluebird instead.
There was a problem hiding this comment.
fs.promises seems less well maintained than fse ?!
There was a problem hiding this comment.
nope, fs.promises is a new feature for node.js
There was a problem hiding this comment.
There was a problem hiding this comment.
Gulp 3.9.1 is broken for Node.js 10 nodejs/node#19786 (comment)
I would need to update Gulp to the 4 beta to use fs.promises
| @@ -12,12 +12,14 @@ const source = require('vinyl-source-stream'); | |||
| const buffer = require('vinyl-buffer'); | |||
| const uglify = require('gulp-uglify'); | |||
| const del = require('del'); | |||
| const confCal = require('conf-cal'); | |||
There was a problem hiding this comment.
conf-cal is a csv parser?
There was a problem hiding this comment.
Conf-cal is a parser for the conf-cal textformat parser.
I made the conf-cal concept to make it easy for us to maintain: Here is the raw-data used:
| @@ -114,7 +114,7 @@ <h2 class="home-subhead">Featured Speakers</h2> | |||
|
|
|||
| <li> | |||
|
|
|||
| <a class="speaker" data-key="addaleax"> | |||
| <a class="speaker" href="speakers.html#speaker-addaleax"> | |||
There was a problem hiding this comment.
Could we delete this data-key ??
There was a problem hiding this comment.
Yes, i updated the overlay system to accomodate for it.
|
Could you attach current screenshot? |
|
|
This PR adds the current schedule to the page.
I checked quite a few things but some things are missing
anything. The speakers with lightning talk entries also have no entry.
I think a markdown parser is necessary.