Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review semver-minor backports #228

Closed
5 of 8 tasks
gibfahn opened this issue Jun 7, 2017 · 9 comments
Closed
5 of 8 tasks

Review semver-minor backports #228

gibfahn opened this issue Jun 7, 2017 · 9 comments

Comments

@gibfahn
Copy link
Member

gibfahn commented Jun 7, 2017

I know it's a bit early, but it's probably worth starting to accumulate the list of PRs for which a backport to Node 6 has been requested (as the first one has been requested).

  • Previous Issue: Potential Semver Minor Backports #188
  • Command: branch-diff --reverse --filter-release --require-label=semver-minor --exclude-label=semver-major,meta,dont-land-on-v6.x,backport-requested-to-v6.x up/v6.x up/v8.x

Unsorted

Yes

Manual

@sam-github
Copy link
Contributor

What about nodejs/node#12677 (comment) ?

@gibfahn
Copy link
Member Author

gibfahn commented Jun 8, 2017

What about nodejs/node#12677 (comment) ?

Yep, added.

This is a collaborative list, so if you want to add stuff just do it. These are just semver-minors we should look at, no consensus is necessary to add one to the list.

@refack
Copy link

refack commented Jul 22, 2017

Backported by mistake, so for your consideration: nodejs/node#14427

@srl295
Copy link
Member

srl295 commented Aug 31, 2017

add more ICU versions - yes, this would be good

@MylesBorins
Copy link
Contributor

@Fishrock123
Copy link
Contributor

We (NodeSource) would like to have access to process.ppid in LTS branches - nodejs/node#16839

It requires a libuv upgrade, so we will have to see if that is feasible. If not, I imagine the backport of that particular feature would not be overly complex.

@cjihrig
Copy link
Contributor

cjihrig commented Nov 20, 2017

FWIW, the libuv 1.x release line should continue to be backport-able.

@MylesBorins
Copy link
Contributor

@Fishrock123 which version of libuv? We updated v6.x and v8.x to 1.15.0 in the last minor

There is room for a minor on 6.x and 8.x in February if we want to do it... I would say this isn't likely to land on 4.x though

@Fishrock123
Copy link
Contributor

From the PR:

depends on the libuv 1.16.0 update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants