Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More visibility for TSC on performance issues #940

Closed
mhdawson opened this issue Oct 13, 2020 · 6 comments
Closed

More visibility for TSC on performance issues #940

mhdawson opened this issue Oct 13, 2020 · 6 comments

Comments

@mhdawson
Copy link
Member

I'm wondering if we need a better way to keep the TSC up to date on performance issues. For example:

nodejs/node#34322

Creating this issue, adding to agenda for discussion.

@mcollina
Copy link
Member

I'm highly aware of that issue and I do not really have a solution for it :/. Happy to discuss the story behind that.

(Note that the severe degradation was present in node-v8 last I checked).

@Trott
Copy link
Member

Trott commented Oct 14, 2020

I'm wondering if we need a better way to keep the TSC up to date on performance issues.

What do you hope greater TSC awareness will achieve?

@mhdawson
Copy link
Member Author

@Trott I'm thinking that the TSC should be aware of significant performance regressions affecting the LTS releases, and any which are known in advance of cutting a new Major release.

I understand that people can go search for them, but it seems to like something we should be more proactive about.

@mmarchini
Copy link
Contributor

I'm not sure granular awareness is relevant unless we have a plan to act on it (revert offending commits, block releases, etc.). The problem is most of the recent performance issues I've seen reported on our issue tracker are V8 related and not Node.js related, which makes it harder for us to act on it.

Preventing and fixing regressions is definitely important, but I'm wondering if a working group/task force/strategic initiative would make more sense than making the whole TSC aware. If just awareness is wanted, we can list all issues with performance label on meetings (and maybe discuss recent ones), but that feels a bit out of scope for us.

@mhdawson
Copy link
Member Author

mhdawson commented Nov 2, 2020

@mmarchini I agree that listing all of the issues does not make sense, I was more thinking that the TSC should be aware of significant regressions which are not going to be fixed quickly, even if they are in v8. Still not sure what the best way to address is though.

@mhdawson
Copy link
Member Author

mhdawson commented Jan 4, 2021

Going to close this until I come up with more concrete suggestions.

@mhdawson mhdawson closed this as completed Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@mcollina @Trott @mmarchini @mhdawson and others