Benchmarking for Node Verison 8 -broken by npm upgrade

[mhdawson]

Seems like npm 5 beta in version 8 has broken the benchmark job for version 8.

Most likely because we depend on the location of the .js file as opposed to doing a full install. Need to investigate and fix up path when running with 5.

[mhdawson]

Issue seems to be that .../node/deps/npm/cli.js does not exist in master/v8.x but did exist in earlier node versions. It was simply a wrapper that did:

#!/usr/bin/env node
require('./bin/npm-cli.js')

[mhdawson]

Looks like instructions in Makefile changes from:

node cli.js install -g -f npm ${NPMOPTS}

to

node bin/npm-cli.js install -g -f npm ${NPMOPTS}

in: nodejs/node#12936

So looks like it is on purpose.

[mhdawson]

Testing swapping one command for the other: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-footprint-master/600/console

[mhdawson]

Looks good in the master job, just applying to the 8.x job now.

[mhdawson]

Ok, all green again, closing.