node-test-commit-v8-linux

[mhdawson]

Looks like node-test-commit-v8-linux is failing on 10.x for x86.

https://ci.nodejs.org/job/node-test-commit-v8-linux/1452/

I think it may be related to recent updates to tweak what tests run. @refack can you take a look as I think you made those updates. The job failing is: node-test-commit-custom-suites

[mmarchini]

test/v8-updates is not on v10.x yet and the job is trying to run them anyway. We might want to limit this job to run only on master for now.

[refack]

Updated node-test-commit-custom-suites to skip test if if [ "$CI_JS_SUITES" = "v8-updates" ] && [ "$NODEJS_MAJOR_VERSION" -lt "11" ]
tested with:
https://ci.nodejs.org/job/node-test-commit-custom-suites/43/ (should skip)
https://ci.nodejs.org/job/node-test-commit-custom-suites/44/ (should run and pass)

Full code

#/bin/bash

echo $NODE_NAME

rm -rf build
git clone https://github.com/nodejs/build.git
. ./build/jenkins/scripts/select-compiler.sh

SKIP_MESSAGE="ok"
REVELANT_VERSION=1
if [ "$NODEJS_MAJOR_VERSION" -lt "6" ]
then
  REVELANT_VERSION=
  # 390 is only supported on v6 and later for now
  SKIP_MESSAGE="ok # skipped s390 not supported for versions less than 6, skipping"
fi
RELEVANT_SUITE=1
if [ "$CI_JS_SUITES" = "v8-updates" ] && [ "$NODEJS_MAJOR_VERSION" -lt "11" ]
then
  RELEVANT_SUITE=
fi
JOBS=$(getconf _NPROCESSORS_ONLN)

if [ $REVELANT_VERSION ] && [ $RELEVANT_SUITE ]
then
  NODE_TEST_DIR=${HOME}/node-tmp
  NODE_COMMON_PORT=15000
  PYTHON=python
  FLAKY_TESTS=$FLAKY_TESTS_MODE
  make build-ci -j $JOBS
  python tools/test.py -j $JOBS -p tap --logfile test.tap --mode=release --flaky-tests=dontcare $TEST_ARGS $CI_JS_SUITES
else
  # fake out so we don't get failures
  mkdir out
  echo "1..1" >test.tap
  echo "ok 1 # skip $SKIP_MESSAGE" >> test.tap
  echo "  ---" >> test.tap
  echo "  duration_ms: 4.925" >> test.tap
  echo "  ..." >> test.tap
fi

[github-actions]

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

[mhdawson]

Closing this is stale