Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: add extra M1 macs #2628

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Conversation

AshCripps
Copy link
Member

@nodejs/build-infra can I get 83.147.191.75 added to the test ci and 83.147.191.76 added to the release ci

@richardlau
Copy link
Member

@nodejs/build-infra can I get 83.147.191.75 added to the test ci and 83.147.191.76 added to the release ci

It should be relatively low risk to do this but I'll probably hold off doing so until after the Node.js 16 release goes out today.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau
Copy link
Member

The release machine has been added to the ci-release firewall.

The iptables playbook appears to still work (🎉) but it's erroring against the public CI host because there are stale host entries in secrets that don't have a matching entry in the inventory (i.e. presumably they've been removed but not cleared up from secrets, and also a reason for some of the failures in #2531). I'll let you know when the test machine has been added.

@AshCripps
Copy link
Member Author

Both Machines added to ci

@richardlau
Copy link
Member

FTR I let @AshCripps know that the test machine has been added to the public CI before he added it 😄. I had to update the iptables playbook to filter out entries -- I'll open a PR with the changes.

@AshCripps AshCripps merged commit 3bebf57 into nodejs:master Apr 21, 2021
@AshCripps AshCripps deleted the add-extra-mac branch April 21, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants