-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible: update RHEL 8 cross compiler container #3274
Conversation
The containers have been updated. The iojs+release and node-cross-compile jobs won't use gcc 10 until they are updated to add the I copied some of the arm-fanned job so I could pick up the version selector change. |
Tests failed on Debian 10 (expected, see notes in rvagg/rpi-newer-crosstools#2). New test CI: https://ci.nodejs.org/job/richardlau-node-test-commit-arm-fanned/8/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update RHEL 8 container used for cross compiling for armv7. Add logic to select gcc 10 toolchain for Node.js 20 onwards. Install gcc-toolset-10 host compiler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update RHEL 8 container used for cross compiling for armv7. Add logic to select gcc 10 toolchain for Node.js 20 onwards. Install gcc-toolset-10 host compiler. Refs: rvagg/rpi-newer-crosstools#2 Refs: https://github.com/orgs/nodejs/discussions/45892 Refs: nodejs/node#47067
Update RHEL 8 container used for cross compiling for armv7.
Add logic to select gcc 10 toolchain for Node.js 20 onwards.
Install gcc-toolset-10 host compiler.
Refs: rvagg/rpi-newer-crosstools#2
Refs: https://github.com/orgs/nodejs/discussions/45892
Refs: nodejs/node#47067