Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: update RHEL 8 cross compiler container #3274

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

richardlau
Copy link
Member

Update RHEL 8 container used for cross compiling for armv7.
Add logic to select gcc 10 toolchain for Node.js 20 onwards.
Install gcc-toolset-10 host compiler.

Refs: rvagg/rpi-newer-crosstools#2
Refs: https://github.com/orgs/nodejs/discussions/45892
Refs: nodejs/node#47067

@richardlau
Copy link
Member Author

richardlau commented Mar 31, 2023

The containers have been updated. The iojs+release and node-cross-compile jobs won't use gcc 10 until they are updated to add the cross-compiler-rhel8-armv7-gcc-10-glibc-2.28 label and the VersionSelectorScript.groovy changes merged.

I copied some of the arm-fanned job so I could pick up the version selector change.
Test build with the copied job: https://ci.nodejs.org/job/richardlau-node-test-commit-arm-fanned/4/

@richardlau
Copy link
Member Author

richardlau commented Mar 31, 2023

I copied some of the arm-fanned job so I could pick up the version selector change. Test build with the copied job: https://ci.nodejs.org/job/richardlau-node-test-commit-arm-fanned/4/

Tests failed on Debian 10 (expected, see notes in rvagg/rpi-newer-crosstools#2).
Tests passed on Ubuntu 20.04 🎉. I've copied the node-test-binary-armv7l job and modified it to use the VersionSelectorScript.groovy from this PR (which should cause debian10 to be skipped for Node.js 20).

New test CI: https://ci.nodejs.org/job/richardlau-node-test-commit-arm-fanned/8/

Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Update RHEL 8 container used for cross compiling for armv7.
Add logic to select gcc 10 toolchain for Node.js 20 onwards.
Install gcc-toolset-10 host compiler.
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau merged commit d20d4a0 into nodejs:main Apr 3, 2023
targos pushed a commit to targos/nodejs-build that referenced this pull request Apr 7, 2023
Update RHEL 8 container used for cross compiling for armv7.
Add logic to select gcc 10 toolchain for Node.js 20 onwards.
Install gcc-toolset-10 host compiler.

Refs: rvagg/rpi-newer-crosstools#2
Refs: https://github.com/orgs/nodejs/discussions/45892
Refs: nodejs/node#47067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants