-
Notifications
You must be signed in to change notification settings - Fork 148
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
George Adams
committed
Jan 16, 2017
1 parent
36362fe
commit 568f7bb
Showing
1 changed file
with
16 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
## Making changes to CitGM | ||
#### There are a few basic requirements for making changes to CitGM | ||
|
||
* Create an issue prior to submitting PR's as this can help speed up the process | ||
* Include tests for your code wherever possible | ||
* Include any documentation or manual changes where necessary | ||
* Ensure that `npm test` passes before submitting the PR | ||
* Please squash each logical change into one single commit | ||
* Follow the nodejs commit guidelines shown [here](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit) | ||
|
||
## Flaky and Skip Changes to lookup.json | ||
The process for adding flaky or skip tags to the lookup.json is reasonably simple. Make your changes put together a PR with ideally a link to the community CI failing and then it will be reviewed. | ||
|
||
|
||
## Submitting a module to CitGM | ||
[Read the module requirements](README.md#requirements-for-inclusion-in-nodejs-citgm-runs) |