Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Tracing WG meeting? Thursday next week? (The 12th March) #6

Closed
GlenTiki opened this issue Mar 6, 2015 · 32 comments
Closed

Next Tracing WG meeting? Thursday next week? (The 12th March) #6

GlenTiki opened this issue Mar 6, 2015 · 32 comments

Comments

@GlenTiki
Copy link

GlenTiki commented Mar 6, 2015

Its been a while since we had one. I want to do some work on the tracing hook area, but haven't touched it since the v8 trace_event thing came out.

@mikeal
Copy link
Contributor

mikeal commented Mar 6, 2015

I think we've been waiting on the trace_event stuff to land before doing another one but the unified system hook stuff can be done without waiting for that.

@Qard
Copy link
Member

Qard commented Mar 6, 2015

Yep, that's pretty much it. We could use some further discussion on the unified tracing and async_wrap stuff though.

@GlenTiki
Copy link
Author

GlenTiki commented Mar 6, 2015

Well then should we just wait for it to land? We can hold off until it lands. :)

@mikeal
Copy link
Contributor

mikeal commented Mar 6, 2015

Someone needs to write the unified tracing endpoint, could be you ;)

@GlenTiki
Copy link
Author

GlenTiki commented Mar 6, 2015

I started work on it on my fork, but got stuck with the ECW stuff... Granted, I started at 4am after a meetup... 😛

I should get back to it again. 😄

@Qard
Copy link
Member

Qard commented Mar 7, 2015

Another thing to add to the agenda: a polyfill for async_wrap, similar to what https://github.com/othiym23/async-listener is for AsyncListener. I believe @othiym23 may already be looking into it. I want to get something built for that and get continuation-local-storage updated. Mostly my interest is to clarify what work is being done and who will be responsible for what.

@hayes
Copy link

hayes commented Mar 9, 2015

I would be interested in helping with a polyfill, I have not spent enough time with async_wrap yet to know what the problem areas will be.

@bnoordhuis
Copy link
Member

What time (UTC / CET) would the call be? Also, has anyone written up a proposal on unified tracing yet?

@Qard
Copy link
Member

Qard commented Mar 11, 2015

There are several ideas that were presented here: nodejs/node#729. No exact implementation has been defined though.

I put together a doodle for the last half of next week. It might be a bit late to coordinate something for this week. http://doodle.com/4d2g2s359qw7ibbv

@GlenTiki
Copy link
Author

I've looked into doing the unified trace area as I described in my gist, but the ecw stuff is messy compared to the others, I'll muddle around with it some more by that meeting https://gist.github.com/thekemkid/c51ed25eb3a5a603cb7e

@Qard
Copy link
Member

Qard commented Mar 16, 2015

@natduca @ofrobots You have anything new to say yet on trace_event?

@trevnorris How about async_wrap? What still needs to be done there?

@ofrobots
Copy link
Contributor

Here's the first CL from Fadi on getting trace-event into V8: https://codereview.chromium.org/988893003/. We are hoping that we can get all the CLs in March. I hoping to start playing with trace_event too, but haven't gotten an opportunity to do that yet.

@trevnorris
Copy link

@Qard What still needs to get done:

  • Integrate with the JS of timers and nextTick()
  • Integrate with Promises (depends on V8)
  • Allow PROVIDER filters
  • Pass the PROVIDER type of the call as argument to callbacks
  • Create C++ callbacks for native hooks
  • (EDIT) Error handling of async stacks

That's just off the top of my head.

@AndreasMadsen
Copy link
Member

@Qard @trevnorris I would like to add:

  • Allow try/catch/finally like error handing
  • Add tests. Will particularly be useful for the guys writing a polyfill

@trevnorris
Copy link

@AndreasMadsen Agreed on the tests. My original error handling code would allow intercepting the bubbled exception before it hit unhandledException. This would also allow viewing the stack from the entry point of the async call. I'm fine with re-implementing that.

@AndreasMadsen
Copy link
Member

@trevnorris Yes that is exactly what I meant. Right now I'm monkey patching process._fatalException to get around it.

@trevnorris
Copy link

@AndreasMadsen glad we're on the same page. I've added that to my list.

@Qard
Copy link
Member

Qard commented Mar 17, 2015

It looks like everyone is good for Thursday or Friday at 1PM. If anyone else wants in on this and hasn't submitted times already, please do so now. If nothing changes in the next 24 hours, I'm going with Friday at 1PM.

@bnoordhuis
Copy link
Member

@Qard 1 PM in what timezone? I'm somewhat suspicious of that doodle taking my timezone into account.

@Qard
Copy link
Member

Qard commented Mar 18, 2015

@bnoordhuis PST.

@GlenTiki
Copy link
Author

@Qard some stuff is after coming up for me and I might not be able to make it, but hopefully I can put together a gist of any info I have on unified tracing (Not much right now, but some). Sorry about this.

@wraithan
Copy link
Contributor

Added myself to the poll. Thursday is mostly shot for me, but Friday works.

@Qard
Copy link
Member

Qard commented Mar 19, 2015

Friday at 1PM it is.

Agenda:

  • async_wrap polyfill (ownership, browser support, etc)
  • unified tracing progress
  • trace_event?

Anyone have anything further to add to the agenda?

@trevnorris
Copy link

1PM PDT?

@bnoordhuis
Copy link
Member

/me changes his 'are you coming?' status to 'maybe'

@Qard
Copy link
Member

Qard commented Mar 20, 2015

@trevnorris Yes. PDT/PST, same thing right now.

@trevnorris
Copy link

I'm AFK ATM and can't find the link. I'll jump on if I can.

@othiym23
Copy link

@trevnorris https://plus.google.com/hangouts/_/hoaevent/AP36tYcMH6Mv9LtAoe101G89VsMmQXgZ2eKBeLtn3MOiHVUdWbRf7w?authuser=0&hl=en is the participant link for the Hangout. Things are sort of shambolic here so far, but we'd love to have your input.

@trevnorris
Copy link

@othiym23 And hangout fail for the phone. Apologies for not being on today.

@othiym23
Copy link

@trevnorris We missed you. ;) See the notes for some of the open topics we'd love to discuss with you.

@sam-github
Copy link

Is there a link to the discussion?

@trevnorris
Copy link

@othiym23 thanks. i'll look at the issues that have been created. Also left a couple notes on the doc.

@Qard Qard closed this as completed Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests