This repository has been archived by the owner on Jul 6, 2018. It is now read-only.
http2: improve header single value checking #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
jasnell
force-pushed
the
improved-single-value-checking
branch
from
14f31a6
to
5125567
Compare
jasnell
force-pushed
the
improved-single-value-checking
branch
from
5125567
to
60479f9
Compare
jasnell
added a commit
that referenced
this pull request
May 17, 2017
PR-URL: #129 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
Landed |
jasnell
added a commit
that referenced
this pull request
May 19, 2017
PR-URL: #129 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Closed
jasnell
added a commit
that referenced
this pull request
May 31, 2017
PR-URL: #129 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
added a commit
to jasnell/http2-1
that referenced
this pull request
Jun 22, 2017
PR-URL: nodejs#129 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
added a commit
to jasnell/http2-1
that referenced
this pull request
Jul 10, 2017
PR-URL: nodejs#129 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
added a commit
to jasnell/http2-1
that referenced
this pull request
Jul 14, 2017
PR-URL: nodejs#129 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this could be a lot better but it's an improvement over what it was. Will need to play around with the implementation to come up with something that performs better.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2