Skip to content
This repository has been archived by the owner on Jul 6, 2018. It is now read-only.

http2: Do not imply a callback to compat res.write #137

Closed
wants to merge 1 commit into from
Closed

http2: Do not imply a callback to compat res.write #137

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

Fixes: #135

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@mcollina mcollina requested a review from jasnell May 18, 2017 16:12
cjihrig

This comment was marked as off-topic.

Sign in to view

jasnell

This comment was marked as off-topic.

Sign in to view

@mcollina
Copy link
Member Author

@jasnell @sebdeckers updated.

mcollina

This comment was marked as off-topic.

Sign in to view

sebdeckers

This comment was marked as off-topic.

Sign in to view

sebdeckers

This comment was marked as off-topic.

Sign in to view

cjihrig

This comment was marked as off-topic.

Sign in to view

mcollina added a commit that referenced this pull request May 19, 2017
@mcollina
http2: Do not imply a callback to compat res.write
cf8b5da 
Fixes: #135
PR-URL: #137
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@mcollina
Copy link
Member Author

Landed in cf8b5da.

@mcollina mcollina closed this May 19, 2017
@mcollina mcollina deleted the fix-callback2 branch May 19, 2017 13:23
jasnell pushed a commit that referenced this pull request May 19, 2017
@mcollina @jasnell
http2: Do not imply a callback to compat res.write
db39eff 
Fixes: #135
PR-URL: #137
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit that referenced this pull request May 31, 2017
@mcollina @jasnell
http2: Do not imply a callback to compat res.write
3c6b987 
Fixes: #135
PR-URL: #137
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit to jasnell/http2-1 that referenced this pull request Jun 22, 2017
@mcollina @jasnell
http2: Do not imply a callback to compat res.write
2a83a0e 
Fixes: nodejs#135
PR-URL: nodejs#137
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit to jasnell/http2-1 that referenced this pull request Jul 10, 2017
@mcollina @jasnell
http2: Do not imply a callback to compat res.write
4feec32 
Fixes: nodejs#135
PR-URL: nodejs#137
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit to jasnell/http2-1 that referenced this pull request Jul 14, 2017
@mcollina @jasnell
http2: Do not imply a callback to compat res.write
619ce80 
Fixes: nodejs#135
PR-URL: nodejs#137
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jasnell jasnell jasnell left review comments

@cjihrig cjihrig cjihrig approved these changes

@sebdeckers sebdeckers sebdeckers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False assumption that a callback exists?
4 participants
@mcollina @sebdeckers @jasnell @cjihrig