-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix segmentation fault when using setters or getters that are not defined #148
Fix segmentation fault when using setters or getters that are not defined #148
Conversation
Sorry I've not had a chance to check this out yet. I'm out at Node Interactive this week but will try to get to it when I have spare time. |
Seems like this PR #159 is fixing the same/similar problem. That PR does not seem to have the change you needed to make sure the test failed. Can you take a look at that PR and then potentially revise this one to have what would still be needed after that ? |
I fixed the conflicts, added a write only test and fixed a segfault that was caused by a missing If the other PR is merged we can still update the segfault logic and fix of course. |
Ok, my plan is to land the other PR, ask you to rebase and then I can go ahead and land this one. Sorry for taking so long to review this one.... |
Ok other PR has landed, if you can rebase that would be great. |
👍 done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fail test suite if child process receives a signal. Fixes segfault in test. PR-URL: #148 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Landed as 22be609 |
Fail test suite if child process receives a signal. Fixes segfault in test. PR-URL: nodejs/node-addon-api#148 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Fail test suite if child process receives a signal. Fixes segfault in test. PR-URL: nodejs/node-addon-api#148 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Fail test suite if child process receives a signal. Fixes segfault in test. PR-URL: nodejs/node-addon-api#148 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Fail test suite if child process receives a signal. Fixes segfault in test. PR-URL: nodejs/node-addon-api#148 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Currently the following scenario aborts with a segmentation fault:
This PR fixes that scenario by checking for a null getter/setter and setting the property descriptor accordingly. Includes a test case for readonly properties.
I had to modify the test runner to correctly report SIGSEGV in order for it to actually fail the tests.