Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Commit 308d6b5

Browse files
kfarnungchakrabot
authored andcommitted
deps: update ChakraCore to chakra-core/ChakraCore@fdd885bc8c
[MERGE #4592 @kfarnung] Add TTD record to the JsConvertValueToString fast path Merge pull request #4592 from kfarnung:ttdstrings JsConvertValueToString can implicitly marshal values between script contexts. Even if there's no conversion occurring the result still needs to be recorded. Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
1 parent 04bfbc7 commit 308d6b5

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

deps/chakrashim/core/lib/Jsrt/Jsrt.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1232,10 +1232,14 @@ CHAKRA_API JsConvertValueToString(_In_ JsValueRef value, _Out_ JsValueRef *resul
12321232

12331233
if (value != nullptr && Js::JavascriptString::Is(value))
12341234
{
1235-
return ContextAPINoScriptWrapper_NoRecord([&](Js::ScriptContext *scriptContext) -> JsErrorCode {
1235+
return ContextAPINoScriptWrapper([&](Js::ScriptContext *scriptContext, TTDRecorder& _actionEntryPopper) -> JsErrorCode {
1236+
PERFORM_JSRT_TTD_RECORD_ACTION(scriptContext, RecordJsRTVarToStringConversion, (Js::Var)value);
12361237
VALIDATE_INCOMING_REFERENCE(value, scriptContext);
12371238

12381239
*result = value;
1240+
1241+
PERFORM_JSRT_TTD_RECORD_ACTION_RESULT(scriptContext, result);
1242+
12391243
return JsNoError;
12401244
});
12411245
}

0 commit comments

Comments
 (0)