Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Commit 46966a3

Browse files
committed
chakrashim,src: fix build breaks
* Add new shimmed APIs * Remove fail fasts for unimplemented tracing methods * Update startup code for signature changes
1 parent 9bd9834 commit 46966a3

File tree

6 files changed

+5090
-5095
lines changed

6 files changed

+5090
-5095
lines changed

deps/chakrashim/include/v8.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1132,6 +1132,7 @@ class V8_EXPORT Value : public Data {
11321132
bool IsWeakSet() const;
11331133
bool IsPromise() const;
11341134
bool IsProxy() const;
1135+
bool IsModuleNamespaceObject() const;
11351136

11361137
V8_WARN_UNUSED_RESULT MaybeLocal<Boolean> ToBoolean(
11371138
Local<Context> context) const;

deps/chakrashim/lib/chakra_shim.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -606,6 +606,10 @@
606606
return compareType(obj, 'SharedArrayBuffer');
607607
};
608608

609+
utils.isModuleNamespaceObject = function(obj) {
610+
return compareType(obj, 'Module');
611+
};
612+
609613
utils.getSymbolKeyFor = function(symbol) {
610614
return Symbol_keyFor(symbol);
611615
};

deps/chakrashim/src/jsrtcachedpropertyidref.inc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ DEF_IS_TYPE(isWeakSet)
162162
DEF_IS_TYPE(isSymbolObject)
163163
DEF_IS_TYPE(isName)
164164
DEF_IS_TYPE(isSharedArrayBuffer)
165+
DEF_IS_TYPE(isModuleNamespaceObject)
165166

166167

167168
#undef DEF

deps/chakrashim/src/v8v8.cc

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -226,28 +226,24 @@ namespace platform {
226226
void SetTracingController(
227227
v8::Platform* platform,
228228
v8::platform::tracing::TracingController* tracing_controller) {
229-
jsrt::Unimplemented("TracingController");
230229
}
231230
} // namespace platform
232231

233232
namespace platform {
234233
namespace tracing {
235234
void TracingController::StopTracing() {
236-
jsrt::Unimplemented("TracingController");
237235
}
238236

239237
void TracingController::StartTracing(TraceConfig*) {
240-
jsrt::Unimplemented("TracingController");
241238
}
242239

243240
void TracingController::Initialize(TraceBuffer*) {
244-
jsrt::Unimplemented("TracingController");
245241
}
246242

247243
const uint8_t* TracingController::GetCategoryGroupEnabled(
248244
const char* category_group) {
249-
jsrt::Unimplemented("TracingController");
250-
return nullptr;
245+
static uint8_t no = 0;
246+
return &no;
251247
}
252248

253249
uint64_t TracingController::AddTraceEvent(
@@ -257,17 +253,14 @@ namespace tracing {
257253
const uint64_t* arg_values,
258254
std::unique_ptr<v8::ConvertableToTraceFormat>* arg_convertables,
259255
unsigned int flags) {
260-
jsrt::Unimplemented("TracingController");
261256
return 0;
262257
}
263258

264259
void TracingController::UpdateTraceEventDuration(
265260
const uint8_t* category_enabled_flag, const char* name, uint64_t handle) {
266-
jsrt::Unimplemented("TracingController");
267261
}
268262

269263
int64_t TracingController::CurrentTimestampMicroseconds() {
270-
jsrt::Unimplemented("TracingController");
271264
return 0;
272265
}
273266

deps/chakrashim/src/v8value.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,7 @@ IS_TYPE_FUNCTION(IsWeakSet, isWeakSet)
180180
IS_TYPE_FUNCTION(IsSymbolObject, isSymbolObject)
181181
IS_TYPE_FUNCTION(IsName, isName)
182182
IS_TYPE_FUNCTION(IsSharedArrayBuffer, isSharedArrayBuffer)
183+
IS_TYPE_FUNCTION(IsModuleNamespaceObject, isModuleNamespaceObject)
183184

184185
MaybeLocal<Boolean> Value::ToBoolean(Local<Context> context) const {
185186
JsValueRef value;

0 commit comments

Comments
 (0)