Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Commit da6018d

Browse files
author
Mike Kaufman
committed
fixing node-chakracore after taking integration
1 parent fc85d8c commit da6018d

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

lib/internal/bootstrap/node.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,22 @@
3333
// This file contains the V8-specific "%<function>" syntax for accessing
3434
// private functions. This is not supported on ChakraCore and causes a
3535
// parser failure. Inject a cache entry to prevent the file from being
36-
// parsed. Return an array to mimic behavior (required by util.inspect)
36+
// parsed. Return an array to mimic behavior (required by util.inspect).
37+
//
38+
// TODO: below methods need to be implemented to return correct values!
3739
NativeModule._cache['internal/v8'] = {
3840
loaded: true,
3941
exports: {
4042
previewMapIterator: function() { return []; },
4143
previewSetIterator: function() { return []; },
44+
previewWeakMap: function() { return []; },
45+
previewWeakSet: function() { return []; }
4246
},
4347
};
4448
}
4549

50+
51+
4652
setupV8();
4753
setupProcessICUVersions();
4854

0 commit comments

Comments
 (0)