This repository was archived by the owner on Oct 15, 2020. It is now read-only.
Commit ef8cd26
deps: update ChakraCore to chakra-core/ChakraCore@45a175d1c7
[1.8>1.9] [MERGE #4612 @boingoing] OS#13976524: Force scanner to create pid for string constant trailing defer-parsed compact-body lambda
Merge pull request #4612 from boingoing:13976524
Lambda with compact-body which is defer-parsed and which is trailed immediately by a string constant can cause the string constant to miss having a pid created. When we try to load the string constant table in `ByteCodeGenerator`, we'll hit an AV with this pid being nullptr.
Fix by forcing the scanner to create a pid for this string constant - only for the single case of a string constant token immediately following the single-expression lambda body which is defer-parsed.
Test case looks like this:
```
jtmchw => z
'123'
```
Fixes:
https://microsoft.visualstudio.com/web/wi.aspx?id=13976524
Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>1 parent e3d6b28 commit ef8cd26
File tree
3 files changed
+31
-0
lines changed- deps/chakrashim/core
- lib/Parser
- test/es6
3 files changed
+31
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7101 | 7101 | | |
7102 | 7102 | | |
7103 | 7103 | | |
| 7104 | + | |
| 7105 | + | |
| 7106 | + | |
| 7107 | + | |
| 7108 | + | |
7104 | 7109 | | |
| 7110 | + | |
7105 | 7111 | | |
7106 | 7112 | | |
7107 | 7113 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1414 | 1414 | | |
1415 | 1415 | | |
1416 | 1416 | | |
| 1417 | + | |
| 1418 | + | |
| 1419 | + | |
| 1420 | + | |
| 1421 | + | |
| 1422 | + | |
| 1423 | + | |
1417 | 1424 | | |
1418 | 1425 | | |
1419 | 1426 | | |
| |||
0 commit comments