This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
n-api: implement DataView APIs for ChakraCore #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfarnung
requested review from
digitalinfinity,
kunalspathak,
jasongin and
MSLaguana
|
This change depends on 3ccc5a9 which was merged into ChakraCore and pulled over. |
digitalinfinity
approved these changes
Aug 1, 2017
jasongin
approved these changes
Aug 1, 2017
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Aug 1, 2017
Implemented the DataView APIs for ChakraCore using the existing JSRT APIs as well as one new API, JsGetDataViewInfo. The test case has also been removed from the flaky list. PR-URL: nodejs#351 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Implemented the DataView APIs for ChakraCore using the existing JSRT APIs as well as one new API, JsGetDataViewInfo. The test case has also been removed from the flaky list. PR-URL: nodejs#351 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
jackhorton
pushed a commit
that referenced
this pull request
Aug 11, 2017
Implemented the DataView APIs for ChakraCore using the existing JSRT APIs as well as one new API, JsGetDataViewInfo. The test case has also been removed from the flaky list. PR-URL: #351 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
kfarnung
added a commit
that referenced
this pull request
Aug 11, 2017
Implemented the DataView APIs for ChakraCore using the existing JSRT APIs as well as one new API, JsGetDataViewInfo. The test case has also been removed from the flaky list. PR-URL: #351 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
kfarnung
added a commit
that referenced
this pull request
Aug 14, 2017
Implemented the DataView APIs for ChakraCore using the existing JSRT APIs as well as one new API, JsGetDataViewInfo. The test case has also been removed from the flaky list. PR-URL: #351 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the DataView APIs for ChakraCore using the existing JSRT
APIs as well as one new API, JsGetDataViewInfo. The test case has also
been removed from the flaky list.
Resolves #350
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
n-api