This repository was archived by the owner on Oct 15, 2020. It is now read-only.
Implement Isolate::SetPromiseRejectCallback #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM, are there tests for this we can enable? |
boingoing
approved these changes
Feb 17, 2018
kfarnung
force-pushed
the
promisereject
branch
from
fa3b780 to
d369671
Compare
Contributor
Author
|
Opened the backport PR: chakra-core/ChakraCore#4697 |
Contributor
Author
|
@boingoing I'm currently investigating the obvious test cases. Looks like a couple inspector testcases are now failing, I suspect they always were but without unhandled rejection support they weren't being reported. |
kfarnung
force-pushed
the
promisereject
branch
from
5368e0a to
6318aaa
Compare
Contributor
Author
kfarnung
force-pushed
the
promisereject
branch
from
6318aaa to
b293e5a
Compare
Contributor
Author
|
Re-run CI with x86 fixes: https://ci.nodejs.org/job/chakracore-test-windows/316/ |
kfarnung
force-pushed
the
promisereject
branch
2 times, most recently
from
98affd6 to
c0e1042
Compare
Contributor
Author
MSLaguana
approved these changes
Feb 20, 2018
* Enabled some unhandled rejection tests (but not the Symbol one due to an unrelated issue) * Added a new chakracore baseline for `unhandled_promise_trace_warnings` * Fixed `test-inspector-debug-brk-flag` which had unhandled rejections * Skipped `test-inspector-bindings` which had unhandled rejections PR-URL: nodejs#469 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung
force-pushed
the
promisereject
branch
from
c0e1042 to
219bf8c
Compare
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Feb 23, 2018
* Enabled some unhandled rejection tests (but not the Symbol one due to an unrelated issue) * Added a new chakracore baseline for `unhandled_promise_trace_warnings` * Fixed `test-inspector-debug-brk-flag` which had unhandled rejections * Skipped `test-inspector-bindings` which had unhandled rejections PR-URL: nodejs#469 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 6, 2018
* Enabled some unhandled rejection tests (but not the Symbol one due to an unrelated issue) * Added a new chakracore baseline for `unhandled_promise_trace_warnings` * Fixed `test-inspector-debug-brk-flag` which had unhandled rejections * Skipped `test-inspector-bindings` which had unhandled rejections PR-URL: nodejs#469 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 7, 2018
* Enabled some unhandled rejection tests (but not the Symbol one due to an unrelated issue) * Added a new chakracore baseline for `unhandled_promise_trace_warnings` * Fixed `test-inspector-debug-brk-flag` which had unhandled rejections * Skipped `test-inspector-bindings` which had unhandled rejections PR-URL: nodejs#469 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I temporarily backported chakra-core/ChakraCore@0b61d16 to https://github.com/kfarnung/ChakraCore/tree/promisereject for use in node-chakracore.
Assuming the node-chakracore changes look good we'll have to discuss how the Chakracore changes will flow into the branch.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
chakrashim