This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
chakrashim: fix for nan compatibility #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Local<Value> BooleanObject::New(bool value) { |
There was a problem hiding this comment.
Wonder we should still keep deprecated implementation, in case anybody using deprecated API? It can be removed when the declaration is removed?
There was a problem hiding this comment.
Yeah, i was debating that myself if i should keep it or remove it. AFAIK, no one can use the deprecated because it will fail the build of that module because of V8_DEPRECATED macro, right? But checking v8's code, they have kept it so would be ok to just leave it instead of deleting.
There was a problem hiding this comment.
Maybe using deprecated APIs only result in a build warning by default, not failure?
|
👍 Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
chakrashim
Description of change
nan was failing to build because of change in signature. Fixed it and deprecated old API.
Fixes: #90