From d796dd5eac383177624a2c4b9284770c99ec3968 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Wed, 7 Aug 2024 10:47:30 -0400 Subject: [PATCH] fix(git-node): ignore codecov check suite (#838) --- lib/pr_checker.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/pr_checker.js b/lib/pr_checker.js index 7d00ca92..b37314e4 100644 --- a/lib/pr_checker.js +++ b/lib/pr_checker.js @@ -29,6 +29,7 @@ const GITHUB_SUCCESS_CONCLUSIONS = ['SUCCESS', 'NEUTRAL', 'SKIPPED']; const FAST_TRACK_RE = /^Fast-track has been requested by @(.+?)\. Please 👍 to approve\.$/; const FAST_TRACK_MIN_APPROVALS = 2; const GIT_CONFIG_GUIDE_URL = 'https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork'; +const IGNORED_CHECK_SLUGS = ['dependabot', 'codecov']; // eslint-disable-next-line no-extend-native Array.prototype.findLastIndex ??= function findLastIndex(fn) { @@ -373,9 +374,9 @@ export default class PRChecker { // GitHub new Check API for (const { status, conclusion, app } of checkSuites.nodes) { - if (app && app.slug === 'dependabot') { - // Ignore Dependabot check suites. They are expected to show up - // sometimes and never complete. + if (app && IGNORED_CHECK_SLUGS.includes(app.slug)) { + // Ignore Dependabot and Codecov check suites. + // They are expected to show up sometimes and never complete. continue; }