ci: tweak patterns, improve markdown output #275
Conversation
There was a problem hiding this comment.
There one minor linting error and looks like test are failing for jenkins tests!
lib/ci/ci_result_parser.js
Outdated
| for (const type of Object.keys(aggregates)) { | ||
| output += `\n### ${FAILURE_TYPES_NAME[type]}\n\n`; | ||
| for (const item of aggregates[type]) { | ||
| const { reason, type, prs, failures, machines } = item; | ||
| if (prs.length < 2) { continue; } | ||
| output += markdownRow('Reason', `\`${reason}\``); | ||
| todo.push(reason) |
There was a problem hiding this comment.
Linting error: missing semicolon here.
|
There used to be a (sort-of) bug in the parser, where a pattern returns the failure object without wrapping it in the array - it's fine in practice since the arrays will be eventually flattened, but returning an array now breaks the test because the |
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 76.47% 75.73% -0.75%
==========================================
Files 22 22
Lines 1356 1364 +8
==========================================
- Hits 1037 1033 -4
- Misses 319 331 +12
Continue to review full report at Codecov.
|
New format is in nodejs/reliability#14 Added a few more patterns and linkify the machine names as well as console of example stacks