-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality for daily-master to NCU-CI #379
Conversation
3474d20
to
e4eaa1c
Compare
For context: we're looking to get ncu-ci running against daily builds, because, by definition, any failure on master is either a failure in the infrastructure, or a flaky test. |
We're trying to figure out if we should push it forward because its useful and achievable, or perhaps whether its a bit of an improvement already and can be merged, or perhaps it was just an interesting experiment and we should abandon it. @joyeecheung what do you think? |
@sam-github Is there a summary of what this does? AFAICT it just adds some logic so that the command can be used on daily build data and it adds some logic to make it more fail-safe? |
The intention was just this,
but maybe some other logic was added as needed. |
@sam-github I think this should be good to get in with the commented code removed |
8e60e6d
to
96fd884
Compare
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
==========================================
- Coverage 77.35% 75.03% -2.33%
==========================================
Files 21 21
Lines 1572 1626 +54
==========================================
+ Hits 1216 1220 +4
- Misses 356 406 +50
Continue to review full report at Codecov.
|
ive rebased and removed the commented code. |
62c31ed
to
0ef4e1e
Compare
0ef4e1e
to
fcb5eef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me from a code-structure POV, it is mostly additive now, leaving for @joyeecheung to have the final review and to land.
Can this be landed? I dont have permission to merge. |
cc @nodejs/automation-collaborators |
fcb5eef
to
0d29c59
Compare
Ive rebased this against master so is free to be landed again |
@sam-github heres my draft for what I have so far.