Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for daily-master to NCU-CI #379

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

AshCripps
Copy link
Member

@sam-github heres my draft for what I have so far.

@sam-github
Copy link
Contributor

For context: we're looking to get ncu-ci running against daily builds, because, by definition, any failure on master is either a failure in the infrastructure, or a flaky test.

@sam-github
Copy link
Contributor

We're trying to figure out if we should push it forward because its useful and achievable, or perhaps whether its a bit of an improvement already and can be merged, or perhaps it was just an interesting experiment and we should abandon it.

@joyeecheung what do you think?

@joyeecheung
Copy link
Member

@sam-github Is there a summary of what this does? AFAICT it just adds some logic so that the command can be used on daily build data and it adds some logic to make it more fail-safe?

@sam-github
Copy link
Contributor

The intention was just this,

adds some logic so that the command can be used on daily build data

but maybe some other logic was added as needed.

@joyeecheung
Copy link
Member

@sam-github I think this should be good to get in with the commented code removed

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #379 into master will decrease coverage by 2.32%.
The diff coverage is 32.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   77.35%   75.03%   -2.33%     
==========================================
  Files          21       21              
  Lines        1572     1626      +54     
==========================================
+ Hits         1216     1220       +4     
- Misses        356      406      +50     
Impacted Files Coverage Δ
lib/ci/ci_result_parser.js 48.14% <30.00%> (-4.31%) ⬇️
lib/ci/ci_type_parser.js 81.53% <100.00%> (+0.28%) ⬆️
lib/cli.js 90.41% <0.00%> (+1.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fe936f...0d29c59. Read the comment docs.

@AshCripps
Copy link
Member Author

ive rebased and removed the commented code.

@AshCripps AshCripps marked this pull request as ready for review May 29, 2020 13:34
@sam-github sam-github changed the title [WIP] Add functionality for daily-master to NCU-CI Add functionality for daily-master to NCU-CI May 29, 2020
lib/ci/ci_result_parser.js Outdated Show resolved Hide resolved
lib/ci/ci_result_parser.js Outdated Show resolved Hide resolved
lib/ci/ci_result_parser.js Outdated Show resolved Hide resolved
lib/ci/ci_result_parser.js Outdated Show resolved Hide resolved
@AshCripps AshCripps force-pushed the add-daily-master branch 2 times, most recently from 62c31ed to 0ef4e1e Compare May 29, 2020 15:20
Copy link
Contributor

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me from a code-structure POV, it is mostly additive now, leaving for @joyeecheung to have the final review and to land.

@AshCripps
Copy link
Member Author

Can this be landed? I dont have permission to merge.

@richardlau
Copy link
Member

Can this be landed? I dont have permission to merge.

cc @nodejs/automation-collaborators

@AshCripps
Copy link
Member Author

Ive rebased this against master so is free to be landed again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants