fix: reduce one level promise

Windows seems to be hanging, hopefully this reduces the number of
promises in the chain.

Author: imatlopez

lib/install.js

@@ -188,7 +188,7 @@ async function install (fs, gyp, argv) {
     const installVersionPath = path.resolve(devDir, 'installVersion')
     await Promise.all([
       // need to download node.lib
-      ...(win ? [downloadNodeLib()] : []),
+      ...(win ? downloadNodeLib() : []),
       // write the "installVersion" file
       fs.promises.writeFile(installVersionPath, gyp.package.installVersion + '\n'),
       // Only download SHASUMS.txt if we downloaded something in need of SHA verification
@@ -228,10 +228,10 @@ async function install (fs, gyp, argv) {
       log.verbose('checksum data', JSON.stringify(expectShasums))
     }
 
-    async function downloadNodeLib () {
+    function downloadNodeLib () {
       log.verbose('on Windows; need to download `' + release.name + '.lib`...')
       const archs = ['ia32', 'x64', 'arm64']
-      return Promise.all(archs.map(async (arch) => {
+      return archs.map(async (arch) => {
         const dir = path.resolve(devDir, arch)
         const targetLibPath = path.resolve(dir, release.name + '.lib')
         const { libUrl, libPath } = release[arch]
@@ -264,7 +264,7 @@ async function install (fs, gyp, argv) {
           }),
           fs.createWriteStream(targetLibPath)
         )
-      }))
+      })
     } // downloadNodeLib()
   } // go()
 

test/test-download.js

@@ -93,7 +93,8 @@ test('download over http with proxy', (t) => {
     pserver.listen(port + 1, host, async () => {
       const gyp = {
         opts: {
-          proxy: `http://${host}:${port + 1}`
+          proxy: `http://${host}:${port + 1}`,
+          noproxy: 'bad'
         },
         version: '42'
       }