Fix: module compilation within termux-app on android #1340
Conversation
addon.gypi
Outdated
| [ 'OS == "android"', { | ||
| 'cflags': [ '-fPIC' ], | ||
| 'cflags_cc': ['-fPIC' ], | ||
| }], |
There was a problem hiding this comment.
You can fold this into the previous condition: OS in "android freebsd ...". You don't need to add it to cflags_cc because cflags is for both C and C++ code.
There was a problem hiding this comment.
@bnoordhuis thanks for your comment. Your proposal was my first attemp to fix it, but it didn't. To verify if I didn't make any mistake I just did some testing:
- with 'cflags_cc': ['-fPIC' ] it compiles
- without 'cflags_cc': ['-fPIC' ] it does not
I think I have to compare the verbose outputs in more detail to figure out what happens. Any ideas?
There was a problem hiding this comment.
env V=1 node-gyp rebuild turns on verbose compilation mode (i.e., prints the compile commands.)
There was a problem hiding this comment.
This is the compiler command for the variant without ccflags_cc. It seems that the -fPIE after the first -fPIC creates and unlinkable shared library on android.
... -fPIC -Wall -Wextra -Wno-unused-parameter -O3 -fno-omit-frame-pointer -fPIE -fno-rtti ...
With ccflags_cc the command is build like that. It seems, that the later -fPIC overrides the preceding -fPIE so that it produces the right shared library.
... -fPIC -Wall -Wextra -Wno-unused-parameter -O3 -fno-omit-frame-pointer -fPIE -fPIC -fno-rtti ...
With this result I would rather try to remove the -fPIE while compiling shared libraries on android. I added an additional entry in target_condition for removing -fPIE like shown below. That did the trick and produces the following compiler command.
... -fPIC -Wall -Wextra -Wno-unused-parameter -O3 -fno-omit-frame-pointer -fno-rtti ...
Excerpt of my local addon.gypi:
'target_conditions': [
...
['library=="shared_library"', {
'conditions': [
[ 'OS=="android"', {
'cflags!': [ '-fPIE' ],
}]
]
}],
...
]
@bnoordhuis, what is your comment on this?
There was a problem hiding this comment.
Ah, you're probably getting hit by #1118 - that -fPIE flag is not set by node-gyp, it's inherited from node's common.gypi.
The right thing to do until #1118 is resolved is probably to suppress the flag in node-gyp's addon.gypi.
It must have been broken for quite a while because that flag was added 20 months ago in nodejs/node#5544.
addon.gypi
Outdated
| @@ -52,6 +52,14 @@ | |||
| 'standalone_static_library': '<(standalone_static_library)' | |||
| }], | |||
|
|
|||
| ['library=="shared_library"', { | |||
There was a problem hiding this comment.
I think you want to unset -fPIE unconditionally, otherwise it's still going to be problematic with add-ons that also build static libraries.
There was a problem hiding this comment.
Ok. So we only want to remove the flag if we don't want to compile an executable. Am I right?
|
LGTM, thanks. CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/42/ You don't even need to special-case on |
|
@bnoordhuis, when can I expect it to be merged and published? |
|
We don't release that often and it also takes a while for new versions of node-gyp make it into npm and node. I can merge it but can you squash your commits and write up a nice commit log? If you want to show up under your real name instead of arrkiin, please do |
|
Hey folks. Would love to see this merged. Running into this issue currently. :) |
|
Hey @bnoordhuis, sorry for the long delay. After your message I asked myself how to proceed and forgot to continue. In the meantime I used my own fork to do the experiments under termux. Until now I didn't see any problems. Today I just found some time to squash the commits and add my forename. |
I can second that. |
PR-URL: #1340 Reviewed-By: Refael Ackermann <refack@gmail.com>
Description of change
To solve the problem of linking a compiled module against a preinstalled library of termux-app on android I added a special condition branch to add the required -fPIC flag for the c and c++ compiler. After that everything compiled, linked and works as expected.