Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve Catalina discoverability for search engines #2135

Closed

Conversation

mmarchini
Copy link
Contributor

@mmarchini mmarchini commented May 19, 2020

By showing the error in the guide, search engines should be able to find
this document when users search for specific lines from the error.

Checklist

By showing the error in the guide, search engines should be able to find
this document when users search for specific lines from the error.
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me, but @cclauss your head is around this stuff more than mine, is this sufficient or are the errors we're trying to deal with more diverse than the specific output here?

@cclauss cclauss changed the title doc: improve cataline discoverability for search engines doc: improve Catalina discoverability for search engines May 19, 2020
Comment on lines 8 to 20
No receipt for 'com.apple.pkg.CLTools_Executables' found at '/'.

No receipt for 'com.apple.pkg.DeveloperToolsCLILeo' found at '/'.

No receipt for 'com.apple.pkg.DeveloperToolsCLI' found at '/'.

gyp: No Xcode or CLT version detected!
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack at ChildProcess.onCpExit (/Users/wtodd/.nvm/versions/node/v13.10.1/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:351:16)
gyp ERR! stack at ChildProcess.emit (events.js:316:20)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
gyp ERR! System Darwin 19.4.0
Copy link
Contributor

@cclauss cclauss May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
No receipt for 'com.apple.pkg.CLTools_Executables' found at '/'.
No receipt for 'com.apple.pkg.DeveloperToolsCLILeo' found at '/'.
No receipt for 'com.apple.pkg.DeveloperToolsCLI' found at '/'.
gyp: No Xcode or CLT version detected!
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack at ChildProcess.onCpExit (/Users/wtodd/.nvm/versions/node/v13.10.1/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:351:16)
gyp ERR! stack at ChildProcess.emit (events.js:316:20)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
gyp ERR! System Darwin 19.4.0
gyp: No Xcode or CLT version detected!

My sense is that this error message should be sufficient. The other lines might might change in different environments ("/Users/wtodd", etc.).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also mark this class of issues with the gyp: No Xcode or CLT version detected! label.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted your suggestion, but, what about using this instead:

No receipt for 'com.apple.pkg.CLTools_Executables' found at '/'.

No receipt for 'com.apple.pkg.DeveloperToolsCLILeo' found at '/'.

No receipt for 'com.apple.pkg.DeveloperToolsCLI' found at '/'.

gyp: No Xcode or CLT version detected!

I can imagine folks searching for the first three lines as well (not everyone will know which lines are the most relevant to search for). Agreed that the last ones are platform dependent (I thought I changed those before committing 😛)

@cclauss cclauss added the gyp: No Xcode or CLT version detected! See: macOS_Catalina.md label May 19, 2020
Co-authored-by: Christian Clauss <cclauss@me.com>
rvagg pushed a commit that referenced this pull request May 26, 2020
By showing the error in the guide, search engines should be able to find
this document when users search for specific lines from the error.

Co-authored-by: Christian Clauss <cclauss@me.com>
PR-URL: #2135
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Christian Clauss <cclauss@me.com>
@rvagg
Copy link
Member

rvagg commented May 26, 2020

963f2a7

@rvagg rvagg closed this May 26, 2020
@rvagg rvagg mentioned this pull request May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants