From 1dd7ad3e6465c5f78d59b1bb9d74e20ea8030940 Mon Sep 17 00:00:00 2001 From: Peter Lyons Date: Mon, 1 Aug 2011 13:39:15 -0400 Subject: [PATCH 1/2] Fix issue 752. Removed check for sent headers for non-mutating getHeader call. --- lib/http.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/http.js b/lib/http.js index 794af64e87a8..27a6096b35d5 100644 --- a/lib/http.js +++ b/lib/http.js @@ -540,10 +540,6 @@ OutgoingMessage.prototype.getHeader = function(name) { throw new Error("`name` is required for getHeader()."); } - if (this._header) { - throw new Error("Can't use mutable header APIs after sent."); - } - if (!this._headers) return; var key = name.toLowerCase(); From 3cb10d096783ef68a17ef281b9742bb4abf48e22 Mon Sep 17 00:00:00 2001 From: Peter Lyons Date: Fri, 12 Aug 2011 13:20:24 -0600 Subject: [PATCH 2/2] Test for getHeader issue 752 --- test/simple/test-http-header-read.js | 58 ++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 test/simple/test-http-header-read.js diff --git a/test/simple/test-http-header-read.js b/test/simple/test-http-header-read.js new file mode 100644 index 000000000000..6d1827d1fbe8 --- /dev/null +++ b/test/simple/test-http-header-read.js @@ -0,0 +1,58 @@ +// Copyright Joyent, Inc. and other Node contributors. +// +// Permission is hereby granted, free of charge, to any person obtaining a +// copy of this software and associated documentation files (the +// "Software"), to deal in the Software without restriction, including +// without limitation the rights to use, copy, modify, merge, publish, +// distribute, sublicense, and/or sell copies of the Software, and to permit +// persons to whom the Software is furnished to do so, subject to the +// following conditions: +// +// The above copyright notice and this permission notice shall be included +// in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS +// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN +// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, +// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +// USE OR OTHER DEALINGS IN THE SOFTWARE. + +var common = require('../common'); +var assert = require('assert'); +var http = require('http'); + +// Verify that ServerResponse.getHeader() works correctly even after +// the response header has been sent. Issue 752 on github. + +var s = http.createServer(function(req, res) { + var contentType = 'Content-Type'; + var plain = 'text/plain'; + res.setHeader(contentType, plain); + res.writeHead(200); + res.end('hello world\n'); + //This checks that after the headers have been sent, getHeader works + //and does not throw an exception (Issue 752) + assert.doesNotThrow( + function() { + assert.equal(plain, res.getHeader(contentType)); + }, + function(err) { + if ( (err instanceof Error) && /mutable header APIs/.test(err) ) { + return true; + } + }, + 'getHeader should not raise an error about mutable APIs' + ); +}); + +s.listen(common.PORT, runTest); + +function runTest() { + http.get({ port: common.PORT }, function(response) { + response.on('end', function() { + s.close(); + }); + }); +}