This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
build: allow custom PackageMaker path #9377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make PACKAGEMAKER customizable because PackageMaker is not necessarily installed in /Developer on OSX anymore.
|
@tjfontaine Can you please take a look? I'll need this to do the v0.10.37 release. Thank you! |
|
yup, this makes sense. LGTM |
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Mar 11, 2015
Make PACKAGEMAKER customizable because PackageMaker is not necessarily installed in /Developer on OSX anymore. PR: nodejs#9377 PR-URL: nodejs#9377 Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
|
@tjfontaine Thank you, landed in 219c80d. |
cjihrig
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 16, 2015
Make PACKAGEMAKER customizable because PackageMaker is not necessarily installed in /Developer on OSX anymore. PR-URL: nodejs/node-v0.x-archive#9377 Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make PACKAGEMAKER customizable because PackageMaker is not necessarily
installed in /Developer on OSX anymore.