From 68808e73736659d456af4d5ef9a8e10505d41d0c Mon Sep 17 00:00:00 2001 From: cjihrig Date: Tue, 19 Dec 2017 10:53:08 -0500 Subject: [PATCH] test: update postmortem metadata test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit updates the following postmortem metadata constants: - v8dbg_class_Map__inobject_properties_or_constructor_function_index__int - This is now v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char as of https://github.com/v8/v8/commit/61bf2cc69217a4e9c7a40bb74269508fa26c2062 - v8dbg_class_Map__instance_attributes__int - This is now v8dbg_class_Map__instance_type__uint16_t as of https://github.com/v8/v8/commit/c00bb6da1cef9f7e9dab842904232255717f8291 and https://github.com/v8/v8/commit/cb46310a799eb0d60a613ead0af8c8200c5338b1 - v8dbg_class_Map__instance_size__int - This is now v8dbg_class_Map__instance_size_in_words__char as of https://github.com/v8/v8/commit/61bf2cc69217a4e9c7a40bb74269508fa26c2062 Refs: https://github.com/nodejs/node-v8/pull/34 Reviewed-By: Ben Noordhuis Reviewed-By: Joyee Cheung Reviewed-By: Michaël Zasso --- test/parallel/test-postmortem-metadata.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/test/parallel/test-postmortem-metadata.js b/test/parallel/test-postmortem-metadata.js index 95d2ff67e1f..0c06108c58b 100644 --- a/test/parallel/test-postmortem-metadata.js +++ b/test/parallel/test-postmortem-metadata.js @@ -37,6 +37,10 @@ assert.strictEqual(missing.length, 0, `Missing constants: ${missing}`); // pushed to the bottom of the file for improved readability. function getExpectedSymbols() { return [ + // Disable the maximum line length for the remainder of the file since it + // should only consist of postmortem constants, and some of them can be + // relatively long. + /* eslint-disable max-len */ 'v8dbg_bit_field3_dictionary_map_shift', 'v8dbg_bit_field3_number_of_own_descriptors_shift', 'v8dbg_class_Code__instruction_size__int', @@ -64,10 +68,10 @@ function getExpectedSymbols() { 'v8dbg_class_JSRegExp__source__Object', 'v8dbg_class_Map__bit_field3__int', 'v8dbg_class_Map__constructor_or_backpointer__Object', - 'v8dbg_class_Map__inobject_properties_or_constructor_function_index__int', - 'v8dbg_class_Map__instance_attributes__int', + 'v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char', + 'v8dbg_class_Map__instance_type__uint16_t', 'v8dbg_class_Map__instance_descriptors__DescriptorArray', - 'v8dbg_class_Map__instance_size__int', + 'v8dbg_class_Map__instance_size_in_words__char', 'v8dbg_class_Oddball__kind_offset__int', 'v8dbg_class_Script__line_ends__Object', 'v8dbg_class_Script__line_offset__SMI',