From 065d8844c57a347c7f2bb52446c2e31b4d2e3e54 Mon Sep 17 00:00:00 2001 From: Liu Jia <109258120+Septa2112@users.noreply.github.com> Date: Thu, 9 Nov 2023 13:45:33 +0800 Subject: [PATCH] benchmark: change iterations in benchmark/es/string-concatenations.js MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Increase the number of iterations from `1e3` to `1e6` to avoid the test performance gap caused by inactive V8 optimization caused by too few iterations. Fixes: https://github.com/nodejs/node/issues/50571 PR-URL: https://github.com/nodejs/node/pull/50585 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Debadree Chatterjee --- benchmark/es/string-concatenations.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/benchmark/es/string-concatenations.js b/benchmark/es/string-concatenations.js index 3c0b27e05019d1..4f9d56cc69df84 100644 --- a/benchmark/es/string-concatenations.js +++ b/benchmark/es/string-concatenations.js @@ -3,7 +3,7 @@ const common = require('../common.js'); const configs = { - n: [1e3], + n: [1e6], mode: [ 'multi-concat', 'multi-join',