From 0682370d9c988f2ae2846eb4f12727e8450e202b Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Wed, 17 Nov 2021 13:10:19 +0100 Subject: [PATCH] test: deflake child-process-pipe-dataflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes: https://github.com/nodejs/node/issues/25988 PR-URL: https://github.com/nodejs/node/pull/40838 Reviewed-By: Michaël Zasso Reviewed-By: Tobias Nießen Reviewed-By: Michael Dawson Reviewed-By: Rich Trott --- test/parallel/test-child-process-pipe-dataflow.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/parallel/test-child-process-pipe-dataflow.js b/test/parallel/test-child-process-pipe-dataflow.js index 2e2edc65e9e0d5..e989ff135c8047 100644 --- a/test/parallel/test-child-process-pipe-dataflow.js +++ b/test/parallel/test-child-process-pipe-dataflow.js @@ -3,7 +3,6 @@ const common = require('../common'); const assert = require('assert'); const path = require('path'); const fs = require('fs'); -const os = require('os'); const spawn = require('child_process').spawn; const tmpdir = require('../common/tmpdir'); @@ -22,12 +21,13 @@ const MB = KB * KB; const file = path.resolve(tmpdir.path, 'data.txt'); const buf = Buffer.alloc(MB).fill('x'); - // Most OS commands that deal with data, attach special - // meanings to new line - for example, line buffering. - // So cut the buffer into lines at some points, forcing - // data flow to be split in the stream. + // Most OS commands that deal with data, attach special meanings to new line - + // for example, line buffering. So cut the buffer into lines at some points, + // forcing data flow to be split in the stream. Do not use os.EOL for \n as + // that is 2 characters on Windows and is sometimes converted to 1 character + // which causes the test to fail. for (let i = 1; i < KB; i++) - buf.write(os.EOL, i * KB); + buf.write('\n', i * KB); fs.writeFileSync(file, buf.toString()); cat = spawn('cat', [file]);