net: fix abort on bad address input

nodejs · Jun 16, 2017 · 097aea4 · 097aea4
1 parent 1e2905f
commit 097aea4
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 7 deletions.
diff --git a/lib/net.js b/lib/net.js
@@ -872,6 +872,10 @@ function internalConnect(
 
   var err;
 
+  if (typeof address !== 'string') {
+    throw new TypeError('Invalid address: ' + address);
+  }
+
   if (localAddress || localPort) {
     debug('binding to localAddress: %s and localPort: %d (addressType: %d)',
           localAddress, localPort, addressType);

diff --git a/test/parallel/test-net-better-error-messages-path.js b/test/parallel/test-net-better-error-messages-path.js
@@ -2,12 +2,23 @@
 const common = require('../common');
 const net = require('net');
 const assert = require('assert');
-const fp = '/tmp/fadagagsdfgsdf';
-const c = net.connect(fp);
 
-c.on('connect', common.mustNotCall());
+{
+  const fp = '/tmp/fadagagsdfgsdf';
+  const c = net.connect(fp);
 
-c.on('error', common.mustCall(function(e) {
-  assert.strictEqual(e.code, 'ENOENT');
-  assert.strictEqual(e.message, `connect ENOENT ${fp}`);
-}));
+  c.on('connect', common.mustNotCall());
+  c.on('error', common.mustCall(function(e) {
+    assert.strictEqual(e.code, 'ENOENT');
+    assert.strictEqual(e.message, `connect ENOENT ${fp}`);
+  }));
+}
+
+{
+  try {
+    net.createConnection({ path: {} });
+    throw new Error('UNREACHABLE');
+  } catch (e) {
+    assert.strictEqual(e.message, 'Invalid address: [object Object]');
+  }
+}