From 0af6e420b35929474837fe784bdbfe556c2f442f Mon Sep 17 00:00:00 2001
From: Daeyeon Jeong <daeyeon.dev@gmail.com>
Date: Fri, 9 Sep 2022 16:10:12 +0900
Subject: [PATCH] stream: remove `abortReason` from
 `WritableStreamDefaultController`

The `abortReason` has been removed from the spec since we can get
the abort reason via `controller.signal.reason`.

This reflects the change.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: https://github.com/nodejs/node/pull/44540
Refs: https://streams.spec.whatwg.org/#ws-default-controller-class-definition
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
---
 doc/api/webstreams.md                       |  4 ----
 lib/internal/webstreams/writablestream.js   | 15 ---------------
 test/parallel/test-whatwg-writablestream.js |  6 ------
 3 files changed, 25 deletions(-)

diff --git a/doc/api/webstreams.md b/doc/api/webstreams.md
index b415113a80975b..6a73a160ee9f67 100644
--- a/doc/api/webstreams.md
+++ b/doc/api/webstreams.md
@@ -978,10 +978,6 @@ changes:
 The `WritableStreamDefaultController` manage's the {WritableStream}'s
 internal state.
 
-#### `writableStreamDefaultController.abortReason`
-
-* Type: {any} The `reason` value passed to `writableStream.abort()`.
-
 #### `writableStreamDefaultController.error(error)`
 
 <!-- YAML
diff --git a/lib/internal/webstreams/writablestream.js b/lib/internal/webstreams/writablestream.js
index c3cd8db9adb595..1e1b64faceab57 100644
--- a/lib/internal/webstreams/writablestream.js
+++ b/lib/internal/webstreams/writablestream.js
@@ -508,15 +508,6 @@ class WritableStreamDefaultController {
     resetQueue(this);
   }
 
-  /**
-   * @type {any}
-   */
-  get abortReason() {
-    if (!isWritableStreamDefaultController(this))
-      throw new ERR_INVALID_THIS('WritableStreamDefaultController');
-    return this[kState].abortReason;
-  }
-
   /**
    * @type {AbortSignal}
    */
@@ -545,7 +536,6 @@ class WritableStreamDefaultController {
 }
 
 ObjectDefineProperties(WritableStreamDefaultController.prototype, {
-  abortReason: kEnumerableProperty,
   signal: kEnumerableProperty,
   error: kEnumerableProperty,
 });
@@ -637,10 +627,6 @@ function writableStreamAbort(stream, reason) {
   if (state === 'closed' || state === 'errored')
     return PromiseResolve();
 
-  // TODO(daeyeon): Remove `controller[kState].abortReason` and use
-  // `controller[kState].abortController.signal.reason` for the
-  // `WritableStreamDefaultController.prototype.abortReason` getter.
-  controller[kState].abortReason = reason;
   controller[kState].abortController.abort(reason);
 
   if (stream[kState].pendingAbortRequest.abort.promise !== undefined)
@@ -1253,7 +1239,6 @@ function setupWritableStreamDefaultController(
   assert(stream[kState].controller === undefined);
   controller[kState] = {
     abortAlgorithm,
-    abortReason: undefined,
     closeAlgorithm,
     highWaterMark,
     queue: [],
diff --git a/test/parallel/test-whatwg-writablestream.js b/test/parallel/test-whatwg-writablestream.js
index 91e3c098462949..fde08c7dd1cd9c 100644
--- a/test/parallel/test-whatwg-writablestream.js
+++ b/test/parallel/test-whatwg-writablestream.js
@@ -198,12 +198,6 @@ class Sink {
     code: 'ERR_INVALID_THIS',
   });
 
-  assert.throws(() => {
-    Reflect.get(WritableStreamDefaultController.prototype, 'abortReason', {});
-  }, {
-    code: 'ERR_INVALID_THIS',
-  });
-
   assert.throws(() => {
     Reflect.get(WritableStreamDefaultController.prototype, 'signal', {});
   }, {