From 0e90f1afc6b6b3780c0186d25d47be9a11a05d91 Mon Sep 17 00:00:00 2001 From: Matheus Marchini Date: Fri, 3 Nov 2017 23:10:10 -0200 Subject: [PATCH] docs: warn users about non-ASCII paths on build The build breaks if there's a non-ASCII character on the path to the building directory. Ref: https://github.com/nodejs/node/issues/16278 Ref: https://github.com/nodejs/node/issues/14336 --- BUILDING.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index c459a867ba6096..1af9bc315c29d1 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -215,7 +215,8 @@ Prerequisites: * **Optional** (to build the MSI): the [WiX Toolset v3.11](http://wixtoolset.org/releases/) and the [Wix Toolset Visual Studio 2017 Extension](https://marketplace.visualstudio.com/items?itemName=RobMensching.WixToolsetVisualStudio2017Extension). -If the path to your build directory contains a space, the build will likely fail. +If the path to your build directory contains a space or a non-ASCII character, the +build will likely fail. ```console > .\vcbuild