Skip to content

Commit

Permalink
test: allow inspector to reopen with same port
Browse files Browse the repository at this point in the history
Test checks that if you open the inspector with '0' (pick a random free
port), close it, then reopen it, you get a different port. However this
isn't necessarily true.

PR-URL: #14320
Fixes: #14316
Refs: #14316 (comment)
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
gibfahn authored and addaleax committed Aug 12, 2017
1 parent 9bbbf12 commit 0eab77c
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion test/parallel/test-inspector-open.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ function tryToCloseWhenClosed(msg) {
function reopenAfterClose(msg) {
assert.strictEqual(msg.cmd, 'url');
const port = url.parse(msg.url).port;
assert.notStrictEqual(port, firstPort);
ping(port, (err) => {
assert.ifError(err);
process.exit();
Expand Down

0 comments on commit 0eab77c

Please sign in to comment.