From 1375af204a30d1885b9e8bf79725cbd223707439 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Wed, 16 Jan 2019 16:23:58 -0500 Subject: [PATCH] test: revert fail `coverage` target if tests fail" This reverts commit f216d5bbb1595f2fbed29517ba87b80e8c02f3c0. Seems like it breaks the nightly job so reverting until we figure that out. PR-URL: https://github.com/nodejs/node/pull/25543 Reviewed-By: Colin Ihrig Reviewed-By: James M Snell --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 1b81eb35525850..9dd9b198491eb3 100644 --- a/Makefile +++ b/Makefile @@ -227,7 +227,7 @@ coverage-test: coverage-build $(RM) out/$(BUILDTYPE)/obj.target/node_lib/gen/*.gcda $(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/*.gcda $(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/tracing/*.gcda - $(MAKE) $(COVTESTS) + -$(MAKE) $(COVTESTS) mv lib lib__ mv lib_ lib mkdir -p coverage .cov_tmp