Skip to content

Commit

Permalink
lib: fix reference leak
Browse files Browse the repository at this point in the history
PR-URL: #44499
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
  • Loading branch information
falsandtru authored and juanarbol committed Oct 4, 2022
1 parent c810813 commit 141eefc
Show file tree
Hide file tree
Showing 3 changed files with 68 additions and 0 deletions.
37 changes: 37 additions & 0 deletions benchmark/process/next-tick-loop-args.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
'use strict';
const common = require('../common.js');
const bench = common.createBenchmark(main, {
n: [1e4, 2e4, 4e4],
loop: [1e2, 2e2],
});

function main({ n, loop }) {
bench.start();
run();
function run() {
let j = 0;

function cb() {
j++;
if (j === n) {
loop--;
if (loop === 0) {
bench.end(n);
} else {
run();
}
}
}

for (let i = 0; i < n; i++) {
if (i % 4 === 0)
process.nextTick(cb, i, true, 10, 'test');
else if (i % 3 === 0)
process.nextTick(cb, i, true, 10);
else if (i % 2 === 0)
process.nextTick(cb, i, 20);
else
process.nextTick(cb, i);
}
}
}
30 changes: 30 additions & 0 deletions benchmark/process/next-tick-loop.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
'use strict';
const common = require('../common.js');
const bench = common.createBenchmark(main, {
n: [1e4, 2e4, 4e4],
loop: [1e2, 2e2],
});

function main({ n, loop }) {
bench.start();
run();
function run() {
let j = 0;

function cb() {
j++;
if (j === n) {
loop--;
if (loop === 0) {
bench.end(n);
} else {
run();
}
}
}

for (let i = 0; i < n; i++) {
process.nextTick(cb);
}
}
}
1 change: 1 addition & 0 deletions lib/internal/fixed_queue.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ module.exports = class FixedQueue {
if (tail.isEmpty() && tail.next !== null) {
// If there is another queue, it forms the new tail.
this.tail = tail.next;
tail.next = null;
}
return next;
}
Expand Down

0 comments on commit 141eefc

Please sign in to comment.