debugger: refactor to use internal modules

This avoids loading the entirety of `node:util` and `node:url` and their dependencies while only a subset is actually used by this module. PR-URL: #38550 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
nodejs · May 17, 2021 · 16a6c8d · 16a6c8d
1 parent 36b9485
commit 16a6c8d
Showing 1 changed file with 17 additions and 16 deletions.
diff --git a/lib/internal/inspector/inspect_repl.js b/lib/internal/inspector/inspect_repl.js
@@ -28,11 +28,12 @@
 const FS = require('fs');
 const Path = require('path');
 const Repl = require('repl');
-const util = require('util');
 const vm = require('vm');
-const fileURLToPath = require('url').fileURLToPath;
+const { fileURLToPath } = require('internal/url');
 
-const debuglog = util.debuglog('inspect');
+const { customInspectSymbol } = require('internal/util');
+const { inspect: utilInspect } = require('internal/util/inspect');
+const debuglog = require('internal/util/debuglog').debuglog('inspect');
 
 const SHORTCUTS = {
   cont: 'c',
@@ -170,12 +171,12 @@ class RemoteObject {
     }
   }
 
-  [util.inspect.custom](depth, opts) {
+  [customInspectSymbol](depth, opts) {
     function formatProperty(prop) {
       switch (prop.type) {
         case 'string':
         case 'undefined':
-          return util.inspect(prop.value, opts);
+          return utilInspect(prop.value, opts);
 
         case 'number':
         case 'boolean':
@@ -184,7 +185,7 @@ class RemoteObject {
         case 'object':
         case 'symbol':
           if (prop.subtype === 'date') {
-            return util.inspect(new Date(prop.value), opts);
+            return utilInspect(new Date(prop.value), opts);
           }
           if (prop.subtype === 'array') {
             return opts.stylize(prop.value, 'special');
@@ -200,7 +201,7 @@ class RemoteObject {
       case 'number':
       case 'string':
       case 'undefined':
-        return util.inspect(this.value, opts);
+        return utilInspect(this.value, opts);
 
       case 'symbol':
         return opts.stylize(this.description, 'special');
@@ -214,10 +215,10 @@ class RemoteObject {
       case 'object':
         switch (this.subtype) {
           case 'date':
-            return util.inspect(new Date(this.description), opts);
+            return utilInspect(new Date(this.description), opts);
 
           case 'null':
-            return util.inspect(null, opts);
+            return utilInspect(null, opts);
 
           case 'regexp':
             return opts.stylize(this.description, 'regexp');
@@ -265,11 +266,11 @@ class ScopeSnapshot {
     this.completionGroup = properties.map((prop) => prop.name);
   }
 
-  [util.inspect.custom](depth, opts) {
+  [customInspectSymbol](depth, opts) {
     const type = `${this.type[0].toUpperCase()}${this.type.slice(1)}`;
     const name = this.name ? `<${this.name}>` : '';
     const prefix = `${type}${name} `;
-    return util.inspect(this.properties, opts)
+    return utilInspect(this.properties, opts)
       .replace(/^Map /, prefix);
   }
 }
@@ -318,7 +319,7 @@ function createRepl(inspector) {
 
   const INSPECT_OPTIONS = { colors: inspector.stdout.isTTY };
   function inspect(value) {
-    return util.inspect(value, INSPECT_OPTIONS);
+    return utilInspect(value, INSPECT_OPTIONS);
   }
 
   function print(value, addNewline = true) {
@@ -358,7 +359,7 @@ function createRepl(inspector) {
   function listScripts(displayNatives = false) {
     print(formatScripts(displayNatives));
   }
-  listScripts[util.inspect.custom] = function listWithoutInternal() {
+  listScripts[customInspectSymbol] = function listWithoutInternal() {
     return formatScripts();
   };
 
@@ -374,7 +375,7 @@ function createRepl(inspector) {
       return p;
     }
 
-    [util.inspect.custom](depth, { stylize }) {
+    [customInspectSymbol](depth, { stylize }) {
       const { startTime, endTime } = this.data;
       const MU = String.fromChar(956);
       return stylize(`[Profile ${endTime - startTime}${MU}s]`, 'special');
@@ -395,7 +396,7 @@ function createRepl(inspector) {
       this.delta = delta;
     }
 
-    [util.inspect.custom](depth, options) {
+    [customInspectSymbol](depth, options) {
       const { scriptId, lineNumber, columnNumber, delta, scriptSource } = this;
       const start = Math.max(1, lineNumber - delta + 1);
       const end = lineNumber + delta + 1;
@@ -461,7 +462,7 @@ function createRepl(inspector) {
   }
 
   class Backtrace extends Array {
-    [util.inspect.custom]() {
+    [customInspectSymbol]() {
       return this.map((callFrame, idx) => {
         const {
           location: { scriptId, lineNumber, columnNumber },