From 178caa56ae17aea78e68d2cf76e1e489b536420f Mon Sep 17 00:00:00 2001 From: Tony Brix Date: Wed, 14 Aug 2019 00:15:10 -0500 Subject: [PATCH] fs: add default options for *stat() PR-URL: https://github.com/nodejs/node/pull/29114 Fixes: https://github.com/nodejs/node/issues/29113 Reviewed-By: Rich Trott Reviewed-By: James M Snell Reviewed-By: Luigi Pinca --- lib/fs.js | 6 +++--- test/parallel/test-fs-stat.js | 11 +++++++++++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/lib/fs.js b/lib/fs.js index baba33a6a2fa8b..2ca3bdf21acab2 100644 --- a/lib/fs.js +++ b/lib/fs.js @@ -796,7 +796,7 @@ function readdirSync(path, options) { return options.withFileTypes ? getDirents(path, result) : result; } -function fstat(fd, options, callback) { +function fstat(fd, options = { bigint: false }, callback) { if (typeof options === 'function') { callback = options; options = {}; @@ -807,7 +807,7 @@ function fstat(fd, options, callback) { binding.fstat(fd, options.bigint, req); } -function lstat(path, options, callback) { +function lstat(path, options = { bigint: false }, callback) { if (typeof options === 'function') { callback = options; options = {}; @@ -819,7 +819,7 @@ function lstat(path, options, callback) { binding.lstat(pathModule.toNamespacedPath(path), options.bigint, req); } -function stat(path, options, callback) { +function stat(path, options = { bigint: false }, callback) { if (typeof options === 'function') { callback = options; options = {}; diff --git a/test/parallel/test-fs-stat.js b/test/parallel/test-fs-stat.js index d52eb6d8fd38d7..bde3e06765cbb8 100644 --- a/test/parallel/test-fs-stat.js +++ b/test/parallel/test-fs-stat.js @@ -154,3 +154,14 @@ fs.stat(__filename, common.mustCall(function(err, s) { } ); }); + +// Should not throw an error +fs.stat(__filename, undefined, common.mustCall(() => {})); + +fs.open(__filename, 'r', undefined, common.mustCall((err, fd) => { + // Should not throw an error + fs.fstat(fd, undefined, common.mustCall(() => {})); +})); + +// Should not throw an error +fs.lstat(__filename, undefined, common.mustCall(() => {}));