From 23f66b137e568b60adf0557d2376161b701c2913 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Tue, 4 Apr 2023 05:19:02 +0200 Subject: [PATCH] test: move test-shadow-realm-gc.js to known_issues There is actually a leak. The test doesn't exercise the right path to create a substantial enough object graph (e.g. accessing something that results in the loading of a binding). This does something more complicated in the test and moves it to known_issues until we find a fix. PR-URL: https://github.com/nodejs/node/pull/47355 Refs: https://github.com/nodejs/node/issues/47353 Reviewed-By: Colin Ihrig Reviewed-By: Chengzhong Wu Reviewed-By: Yagiz Nizipli --- test/known_issues/known_issues.status | 3 +++ test/{parallel => known_issues}/test-shadow-realm-gc.js | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) rename test/{parallel => known_issues}/test-shadow-realm-gc.js (73%) diff --git a/test/known_issues/known_issues.status b/test/known_issues/known_issues.status index 7a50c10404c723..e19a87e7c39b6c 100644 --- a/test/known_issues/known_issues.status +++ b/test/known_issues/known_issues.status @@ -11,6 +11,9 @@ prefix known_issues # foreseeable future. The test itself is flaky and skipped. It # serves as a demonstration of the issue only. test-vm-timeout-escape-queuemicrotask: SKIP +# Skipping it because it crashes out of OOM instead of exiting. +# https://github.com/nodejs/node/issues/47353 +test-shadow-realm-gc: SKIP [$system==win32] diff --git a/test/parallel/test-shadow-realm-gc.js b/test/known_issues/test-shadow-realm-gc.js similarity index 73% rename from test/parallel/test-shadow-realm-gc.js rename to test/known_issues/test-shadow-realm-gc.js index b640c6b8be3f1a..cf15324e5cec06 100644 --- a/test/parallel/test-shadow-realm-gc.js +++ b/test/known_issues/test-shadow-realm-gc.js @@ -8,5 +8,6 @@ require('../common'); for (let i = 0; i < 1000; i++) { - new ShadowRealm(); + const realm = new ShadowRealm(); + realm.evaluate('new TextEncoder(); 1;'); }