From 2b8b224077283906f70edf3d31178c77b9c4b22b Mon Sep 17 00:00:00 2001 From: DeeDeeG Date: Sun, 22 May 2022 06:41:46 -0400 Subject: [PATCH] doc: remove outdated footnote (Python 2 --> 3 for V8 tests) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Various Python 3 compatibility fixes were made in upstream V8, and they have even dropped Python 2 compatibility in various scripts. depot_tools, which bootstraps the V8 build, is also moving to Python 3. As of Node v18.0.0-ish, this footnote is no-longer accurate. (Running `make test-v8` no-longer requires Python 2, and it won't work anymore if you don't have a copy of Python 3.) PR-URL: https://github.com/nodejs/node/pull/43105 Reviewed-By: Michaël Zasso Reviewed-By: Rich Trott Reviewed-By: Tobias Nießen Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca Reviewed-By: Jiawen Geng Reviewed-By: Akhil Marsonya Reviewed-By: Jackson Tian --- doc/contributing/maintaining-V8.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/doc/contributing/maintaining-V8.md b/doc/contributing/maintaining-V8.md index 339cda49488600..466e19b38bfb77 100644 --- a/doc/contributing/maintaining-V8.md +++ b/doc/contributing/maintaining-V8.md @@ -407,10 +407,8 @@ This would require some tooling to: [^1]: Node.js 0.12 and older are intentionally omitted from this document as their support has ended. -[^2]: The V8 tests still require Python 2. To run these tests locally, you can - run `PYTHON2 ./configure.py` before running `make test-v8`, in the root - of this repository. On macOS, this also requires a full Xcode install, - not just the "command line tools" for Xcode. +[^2]: On macOS, the V8 tests require a full Xcode install, not just the "command + line tools" for Xcode. [ChromiumReleaseCalendar]: https://www.chromium.org/developers/calendar [Node.js CI]: https://ci.nodejs.org/job/node-test-pull-request/