From 2e568d95bdd689494b163f1cfe8bbc38f32e45ed Mon Sep 17 00:00:00 2001 From: Myles Borins Date: Fri, 30 Sep 2016 18:31:47 -0400 Subject: [PATCH] lib: remove let from for loops MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a known de-opt. It may not be 100% necessary in all cases but it seems like a decent enough idea to avoid it. PR-URL: https://github.com/nodejs/node/pull/8873 Reviewed-By: Brian White Reviewed-By: Ilkka Myller Reviewed-By: Johan Bergström Reviewed-By: Luigi Pinca Reviewed-By: Michaël Zasso --- lib/_stream_readable.js | 6 +++--- lib/internal/readline.js | 2 +- lib/internal/util.js | 2 +- lib/punycode.js | 8 ++++---- lib/repl.js | 6 +++--- lib/tls.js | 2 +- lib/util.js | 2 +- lib/v8.js | 2 +- 8 files changed, 15 insertions(+), 15 deletions(-) diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js index 5b9087a8737581..9438bf92d34ee2 100644 --- a/lib/_stream_readable.js +++ b/lib/_stream_readable.js @@ -661,14 +661,14 @@ Readable.prototype.unpipe = function(dest) { state.pipesCount = 0; state.flowing = false; - for (let i = 0; i < len; i++) + for (var i = 0; i < len; i++) dests[i].emit('unpipe', this); return this; } // try to find the right one. - const i = state.pipes.indexOf(dest); - if (i === -1) + const index = state.pipes.indexOf(dest); + if (index === -1) return this; state.pipes.splice(i, 1); diff --git a/lib/internal/readline.js b/lib/internal/readline.js index ce22fb9ffb33d8..dbe8775dba3aac 100644 --- a/lib/internal/readline.js +++ b/lib/internal/readline.js @@ -26,7 +26,7 @@ function getStringWidth(str) { str = stripVTControlCharacters(str); - for (let i = 0; i < str.length; i++) { + for (var i = 0; i < str.length; i++) { const code = str.codePointAt(i); if (code >= 0x10000) { // surrogates diff --git a/lib/internal/util.js b/lib/internal/util.js index fd1f3b487c74d7..4ada8dd0cc16f0 100644 --- a/lib/internal/util.js +++ b/lib/internal/util.js @@ -24,7 +24,7 @@ exports.error = function(msg) { if (arguments.length > 1) { const args = new Array(arguments.length); args[0] = fmt; - for (let i = 1; i < arguments.length; ++i) + for (var i = 1; i < arguments.length; ++i) args[i] = arguments[i]; console.error.apply(console, args); } else { diff --git a/lib/punycode.js b/lib/punycode.js index 9d788aefb59087..34da3ca5ad13b6 100644 --- a/lib/punycode.js +++ b/lib/punycode.js @@ -210,7 +210,7 @@ const decode = function(input) { basic = 0; } - for (let j = 0; j < basic; ++j) { + for (var j = 0; j < basic; ++j) { // if it's not a basic code point if (input.charCodeAt(j) >= 0x80) { error('not-basic'); @@ -221,7 +221,7 @@ const decode = function(input) { // Main decoding loop: start just after the last delimiter if any basic code // points were copied; start at the beginning otherwise. - for (let index = basic > 0 ? basic + 1 : 0; index < inputLength; /* no final expression */) { + for (var index = basic > 0 ? basic + 1 : 0; index < inputLength; /* no final expression */) { // `index` is the index of the next character to be consumed. // Decode a generalized variable-length integer into `delta`, @@ -229,7 +229,7 @@ const decode = function(input) { // if we increase `i` as we go, then subtract off its starting // value at the end to obtain `delta`. let oldi = i; - for (let w = 1, k = base; /* no condition */; k += base) { + for (var w = 1, k = base; /* no condition */; k += base) { if (index >= inputLength) { error('invalid-input'); @@ -345,7 +345,7 @@ const encode = function(input) { if (currentValue == n) { // Represent delta as a generalized variable-length integer. let q = delta; - for (let k = base; /* no condition */; k += base) { + for (var k = base; /* no condition */; k += base) { const t = k <= bias ? tMin : (k >= bias + tMax ? tMax : k - bias); if (q < t) { break; diff --git a/lib/repl.js b/lib/repl.js index 7d8bee26cf4ca2..620addc5ef53c0 100644 --- a/lib/repl.js +++ b/lib/repl.js @@ -345,7 +345,7 @@ function REPLServer(prompt, // After executing the current expression, store the values of RegExp // predefined properties back in `savedRegExMatches` - for (let idx = 1; idx < savedRegExMatches.length; idx += 1) { + for (var idx = 1; idx < savedRegExMatches.length; idx += 1) { savedRegExMatches[idx] = RegExp[`$${idx}`]; } @@ -1078,9 +1078,9 @@ function longestCommonPrefix(arr = []) { const first = arr[0]; // complexity: O(m * n) - for (let m = 0; m < first.length; m++) { + for (var m = 0; m < first.length; m++) { const c = first[m]; - for (let n = 1; n < cnt; n++) { + for (var n = 1; n < cnt; n++) { const entry = arr[n]; if (m >= entry.length || c !== entry[m]) { return first.substring(0, m); diff --git a/lib/tls.js b/lib/tls.js index a1813fc87c7de1..32c0319754be2a 100644 --- a/lib/tls.js +++ b/lib/tls.js @@ -100,7 +100,7 @@ function check(hostParts, pattern, wildcards) { return false; // Check host parts from right to left first. - for (let i = hostParts.length - 1; i > 0; i -= 1) + for (var i = hostParts.length - 1; i > 0; i -= 1) if (hostParts[i] !== patternParts[i]) return false; diff --git a/lib/util.js b/lib/util.js index f742e38433927f..edec19bf791ce3 100644 --- a/lib/util.js +++ b/lib/util.js @@ -30,7 +30,7 @@ if (typeof global.SIMD === 'object' && global.SIMD !== null) { const make = (extractLane, count) => { return (ctx, value, recurseTimes, visibleKeys, keys) => { const output = new Array(count); - for (let i = 0; i < count; i += 1) + for (var i = 0; i < count; i += 1) output[i] = formatPrimitive(ctx, extractLane(value, i)); return output; }; diff --git a/lib/v8.js b/lib/v8.js index 551b2ada98526e..e78a2480ff04e7 100644 --- a/lib/v8.js +++ b/lib/v8.js @@ -60,7 +60,7 @@ exports.getHeapSpaceStatistics = function() { const buffer = heapSpaceStatisticsBuffer; v8binding.updateHeapSpaceStatisticsArrayBuffer(); - for (let i = 0; i < kNumberOfHeapSpaces; i++) { + for (var i = 0; i < kNumberOfHeapSpaces; i++) { const propertyOffset = i * kHeapSpaceStatisticsPropertiesCount; heapSpaceStatistics[i] = { space_name: kHeapSpaces[i],