From 308900faef8b2e5edab5f9737495d2d1b3b54ffe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Tue, 5 May 2020 09:19:27 +0200 Subject: [PATCH] src: update NODE_MODULE_VERSION to 84 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.3. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/32831 Reviewed-By: Anna Henningsen Reviewed-By: Michaël Zasso Reviewed-By: Jiawen Geng Reviewed-By: Colin Ihrig --- doc/abi_version_registry.json | 1 + src/node_version.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/abi_version_registry.json b/doc/abi_version_registry.json index c4de6b8719b032..11d09d06515b28 100644 --- a/doc/abi_version_registry.json +++ b/doc/abi_version_registry.json @@ -1,5 +1,6 @@ { "NODE_MODULE_VERSION": [ + { "modules": 84, "runtime": "node", "variant": "v8_8.3", "versions": "15.0.0-pre" }, { "modules": 83, "runtime": "node", "variant": "v8_8.1", "versions": "14.0.0" }, { "modules": 82, "runtime": "electron", "variant": "electron", "versions": "10" }, { "modules": 81, "runtime": "node", "variant": "v8_7.9", "versions": "14.0.0-pre" }, diff --git a/src/node_version.h b/src/node_version.h index 3107cbfc17533e..72405d2914cd0a 100644 --- a/src/node_version.h +++ b/src/node_version.h @@ -89,7 +89,7 @@ * version matching should open a pull request to reserve a number in this * registry. */ -#define NODE_MODULE_VERSION 83 +#define NODE_MODULE_VERSION 84 // The NAPI_VERSION provided by this version of the runtime. This is the version // which the Node binary being built supports.