From 335b61ac7411462d60cb9a7fc750bdcd8329ef36 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Tue, 11 Aug 2020 20:13:09 +0200 Subject: [PATCH] test: skip node-api/test_worker_terminate_finalization The test fails under ASAN/valgrind. Since it has not been working properly until today anyway, skip it. Refs: https://github.com/nodejs/node/issues/34731 PR-URL: https://github.com/nodejs/node/pull/34732 Reviewed-By: James M Snell Reviewed-By: Matheus Marchini --- test/node-api/test_worker_terminate_finalization/test.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/node-api/test_worker_terminate_finalization/test.js b/test/node-api/test_worker_terminate_finalization/test.js index 76cece7bcf3cc4..d58324d5e5f696 100644 --- a/test/node-api/test_worker_terminate_finalization/test.js +++ b/test/node-api/test_worker_terminate_finalization/test.js @@ -1,5 +1,10 @@ 'use strict'; const common = require('../../common'); + +// TODO(addaleax): Run this test once it stops failing under ASAN/valgrind. +// Refs: https://github.com/nodejs/node/issues/34731 +common.skip('Reference management in N-API leaks memory'); + const { Worker, isMainThread } = require('worker_threads'); if (isMainThread) {