From 35310437e8502080fa336d611177c98aa83b4490 Mon Sep 17 00:00:00 2001 From: Vipin Menon Date: Fri, 10 Nov 2017 16:04:07 +0530 Subject: [PATCH] stream: use arrow fns for 'this' in readable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/16927 Reviewed-By: James M Snell Reviewed-By: Tobias Nießen Reviewed-By: Anatoli Papirovski Reviewed-By: Gireesh Punathil Reviewed-By: Franziska Hinkelmann Reviewed-By: Luigi Pinca --- lib/_stream_readable.js | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js index 4fc22ee5b8e01a..725503cc2dbd38 100644 --- a/lib/_stream_readable.js +++ b/lib/_stream_readable.js @@ -853,19 +853,18 @@ Readable.prototype.wrap = function(stream) { var state = this._readableState; var paused = false; - var self = this; - stream.on('end', function() { + stream.on('end', () => { debug('wrapped end'); if (state.decoder && !state.ended) { var chunk = state.decoder.end(); if (chunk && chunk.length) - self.push(chunk); + this.push(chunk); } - self.push(null); + this.push(null); }); - stream.on('data', function(chunk) { + stream.on('data', (chunk) => { debug('wrapped data'); if (state.decoder) chunk = state.decoder.write(chunk); @@ -876,7 +875,7 @@ Readable.prototype.wrap = function(stream) { else if (!state.objectMode && (!chunk || !chunk.length)) return; - var ret = self.push(chunk); + var ret = this.push(chunk); if (!ret) { paused = true; stream.pause(); @@ -897,12 +896,12 @@ Readable.prototype.wrap = function(stream) { // proxy certain important events. for (var n = 0; n < kProxyEvents.length; n++) { - stream.on(kProxyEvents[n], self.emit.bind(self, kProxyEvents[n])); + stream.on(kProxyEvents[n], this.emit.bind(this, kProxyEvents[n])); } // when we try to consume some more bytes, simply unpause the // underlying stream. - self._read = function(n) { + this._read = (n) => { debug('wrapped _read', n); if (paused) { paused = false; @@ -910,7 +909,7 @@ Readable.prototype.wrap = function(stream) { } }; - return self; + return this; };