From 391d2f830a3b861be2ee2adf7204a0c8e660f91b Mon Sep 17 00:00:00 2001
From: Daniel Bevenius <daniel.bevenius@gmail.com>
Date: Tue, 24 Apr 2018 08:45:35 +0200
Subject: [PATCH] crypto: simplify diffiehellman getFormat function
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This commit aims to simplify the getFormat function in
diffiehellman.js.

PR-URL: https://github.com/nodejs/node/pull/20246
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 lib/internal/crypto/diffiehellman.js | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/lib/internal/crypto/diffiehellman.js b/lib/internal/crypto/diffiehellman.js
index 329add6d4d7cd5..dad7a903b26a5e 100644
--- a/lib/internal/crypto/diffiehellman.js
+++ b/lib/internal/crypto/diffiehellman.js
@@ -219,21 +219,15 @@ function encode(buffer, encoding) {
 }
 
 function getFormat(format) {
-  let f;
   if (format) {
     if (format === 'compressed')
-      f = POINT_CONVERSION_COMPRESSED;
-    else if (format === 'hybrid')
-      f = POINT_CONVERSION_HYBRID;
-    // Default
-    else if (format === 'uncompressed')
-      f = POINT_CONVERSION_UNCOMPRESSED;
-    else
+      return POINT_CONVERSION_COMPRESSED;
+    if (format === 'hybrid')
+      return POINT_CONVERSION_HYBRID;
+    if (format !== 'uncompressed')
       throw new ERR_CRYPTO_ECDH_INVALID_FORMAT(format);
-  } else {
-    f = POINT_CONVERSION_UNCOMPRESSED;
   }
-  return f;
+  return POINT_CONVERSION_UNCOMPRESSED;
 }
 
 module.exports = {