From 3a5b5428c6509f91306e10486f1e56e3b1e80195 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Tue, 16 Jul 2024 15:29:10 +0200 Subject: [PATCH] build: disable test-asan workflow It is running on ubuntu-20.04, which will inevitably be removed from GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04 and ubuntu-24.04 have failed. It is now blocking V8 updates because of errors that happen only with the `test-asan` job. Refs: https://github.com/nodejs/node/pull/52374 Refs: https://github.com/nodejs/node/pull/53651#issuecomment-2198510810 PR-URL: https://github.com/nodejs/node/pull/53844 Reviewed-By: Marco Ippolito Reviewed-By: Antoine du Hamel Reviewed-By: Moshe Atlow Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell --- .github/workflows/test-asan.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-asan.yml b/.github/workflows/test-asan.yml index 1d699e2846e6f8..f2767253aa4091 100644 --- a/.github/workflows/test-asan.yml +++ b/.github/workflows/test-asan.yml @@ -38,7 +38,7 @@ permissions: jobs: test-asan: - if: github.event.pull_request.draft == false + if: false # Temporarily disabled. References: https://github.com/nodejs/node/pull/52374, https://github.com/nodejs/node/pull/53651#issuecomment-2198510810 runs-on: ubuntu-20.04 env: CC: sccache clang